Remove conformance tag for internet connectivity#53381
Conversation
ICMP ping is not available in many environments, so we should avoid using a e2e test based the premise as a conformance test.
|
Thanks. This is necessary until we find a better solution. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bgrant0607, dims Associated issue: 52098 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
|
Actually, I think some people may want to run air-gapped Kubernetes clusters that run without any access to the Internet so it makes sense to me to permanently remove this from conformance tests. |
|
I think we also need to cherry pick this to 1.7. |
|
@dims, @bgrant0607: can we backport this patch to 1.7 branch, please? we hit also this same issue |
|
@mjura @kevin-wangzefeng @bgrant0607 - Done! |
What this PR does / why we need it:
ICMP ping is not available in many environments, so we should avoid
using a e2e test based the premise as a conformance test.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Part of Fix for #52098, Please see #51287 for more discussion
Release note: