Skip to content

Automated cherry pick of #53381#53390

Merged
k8s-github-robot merged 1 commit intokubernetes:release-1.8from
dims:automated-cherry-pick-of-#53381-upstream-release-1.8
Oct 5, 2017
Merged

Automated cherry pick of #53381#53390
k8s-github-robot merged 1 commit intokubernetes:release-1.8from
dims:automated-cherry-pick-of-#53381-upstream-release-1.8

Conversation

@dims
Copy link
Member

@dims dims commented Oct 3, 2017

Cherry pick of #53381 on release-1.8.

#53381: Remove conformance tag for internet connectivity

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 3, 2017

@dims: All 'parent' PRs of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement.

Details

The following parent PRs have neither the "release-note" nor the "release-note-action-required" labels: #53381.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 3, 2017

@dims: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

Details

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 3, 2017
@dims
Copy link
Member Author

dims commented Oct 3, 2017

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 3, 2017
@dims
Remove conformance tag for internet connectivity
c722b4a 
ICMP ping is not available in many environments, so we should avoid
using a e2e test based the premise as a conformance test.
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 3, 2017
@jdumars jdumars added this to the v1.8 milestone Oct 3, 2017
@jdumars
Copy link
Contributor

jdumars commented Oct 3, 2017

/lgtm
This is critical path for cloud providers

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2017
@jdumars
Copy link
Contributor

jdumars commented Oct 3, 2017

@jpbetz this is a critical cherrypick for 1.8.1.

@jpbetz
Copy link
Contributor

jpbetz commented Oct 3, 2017

/cherrypick-approved

@jpbetz jpbetz added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 3, 2017
@k8s-github-robot k8s-github-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 3, 2017
@dims
Copy link
Member Author

dims commented Oct 3, 2017

/retest

@jdumars
Copy link
Contributor

jdumars commented Oct 3, 2017

/test pull-kubernetes-e2e-gce-bazel

@jdumars jdumars added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 4, 2017
@jdumars
Copy link
Contributor

jdumars commented Oct 4, 2017

/retest

@jdumars
Copy link
Contributor

jdumars commented Oct 4, 2017

/approve no-issue

@bgrant0607
Copy link
Member

bgrant0607 commented Oct 4, 2017

/approve

@k8s-github-robot
Copy link

k8s-github-robot commented Oct 4, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bgrant0607, dims, jdumars

Associated issue: 53381

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2017
@k8s-github-robot
Copy link

k8s-github-robot commented Oct 5, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

k8s-github-robot commented Oct 5, 2017

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit d92efdf into kubernetes:release-1.8 Oct 5, 2017
@k8s-cherrypick-bot
Copy link

k8s-cherrypick-bot commented Oct 5, 2017

Commit found in the "release-1.8" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@bowei bowei

@jdumars jdumars

@dnardo dnardo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.8

Development

Successfully merging this pull request may close these issues.

9 participants

@dims @k8s-ci-robot @jdumars @jpbetz @bgrant0607 @k8s-github-robot @k8s-cherrypick-bot @bowei @dnardo