Fixed intermitant e2e aggregator test on GKE.#53030
Fixed intermitant e2e aggregator test on GKE.#53030k8s-github-robot merged 1 commit intokubernetes:masterfrom
Conversation
|
/assign @mbohlool |
|
/lgtm |
Fixes issues/50945. Issue was caused by another test cleaning up its namespace. This caused the namespace controller to try to clean up that namespace. This involves deleting all flunders under that namespace. However the sample-apiserver was not honoring the namespace filter. So the flunders for the test would randomly disappear. Fixed image path to pick up newly built fixes from this PR.
|
Did we figure out why the test was only flaking on gke? |
|
Good find. We should open an issue to dry out the places we indicate namespacedness of types (strategy and registration both require specifying it) |
|
/test pull-kubernetes-unit |
|
/test pull-kubernetes-e2e-kops-aws |
|
Were the container images already pushed? And if so, what branch were they built from? |
|
/test pull-kubernetes-e2e-gce-bazel |
|
/test pull-kubernetes-e2e-kops-aws |
1 similar comment
|
/test pull-kubernetes-e2e-kops-aws |
|
/lgtm |
|
Change to the sample apiserver looks good. How was the 17v2 tag built? It should really be built from the release-1.7 branch with this fix applied |
|
/test pull-kubernetes-e2e-kops-aws |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abgworrall, cheftako, mbohlool, sttts Associated issue: 50945 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/retest Review the full test history for this PR. |
1 similar comment
|
/retest Review the full test history for this PR. |
|
/test pull-kubernetes-e2e-kops-aws |
2 similar comments
|
/test pull-kubernetes-e2e-kops-aws |
|
/test pull-kubernetes-e2e-kops-aws |
|
Holding this pending an answer to #53030 (comment) |
|
talked with @cheftako, the image was build from the release-1.7 branch |
|
@liggitt I built it from the 1.7.3 tag. If you want I can go to the head of that branch and build it. |
|
@cheftako as long as it was 1.7, that's fine for now. we should also commit this fix to the actual 1.7 branch |
|
/retest |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/retest |
|
Automatic merge from submit-queue (batch tested with PRs 51648, 53030, 53009). If you want to cherry-pick this change to another branch, please follow the instructions here.. |
…3030-upstream-release-1.8 Automatic merge from submit-queue. Automated cherry pick of #53030 Cherry pick of #53030 on release-1.8. #53030: Fixed intermittant e2e aggregator test on GKE. **What this PR does / why we need it**: Issue was caused by another test cleaning up its namespace. This caused the namespace controller to try to clean up that namespace. This involves deleting all flunders under that namespace. However the sample-apiserver was not honoring the namespace filter. So the flunders for the test would randomly disappear. Relates to issue #50945 **Special notes for your reviewer**: Requires we fix the container image to contain this fix to work.
|
Commit found in the "release-1.8" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
What this PR does / why we need it: Issue was caused by another test cleaning up its namespace.
This caused the namespace controller to try to clean up that namespace.
This involves deleting all flunders under that namespace.
However the sample-apiserver was not honoring the namespace filter.
So the flunders for the test would randomly disappear.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #50945Special notes for your reviewer: Requires we fix the container image to contain this fix to work.
Release note: