Skip to content

Automated cherry pick of #53030#53039

Merged
k8s-github-robot merged 1 commit intokubernetes:release-1.8from
abgworrall:automated-cherry-pick-of-#53030-upstream-release-1.8
Sep 29, 2017
Merged

Automated cherry pick of #53030#53039
k8s-github-robot merged 1 commit intokubernetes:release-1.8from
abgworrall:automated-cherry-pick-of-#53030-upstream-release-1.8

Conversation

@abgworrall
Copy link
Copy Markdown
Contributor

@abgworrall abgworrall commented Sep 26, 2017

Cherry pick of #53030 on release-1.8.

#53030: Fixed intermittant e2e aggregator test on GKE.

What this PR does / why we need it: Issue was caused by another test cleaning up its namespace.
This caused the namespace controller to try to clean up that namespace.
This involves deleting all flunders under that namespace.
However the sample-apiserver was not honoring the namespace filter.
So the flunders for the test would randomly disappear.

Relates to issue #50945

Special notes for your reviewer: Requires we fix the container image to contain this fix to work.

Fixes issues/50945.
Issue was caused by another test cleaning up its namespace.
This caused the namespace controller to try to clean up that namespace.
This involves deleting all flunders under that namespace.
However the sample-apiserver was not honoring the namespace filter.
So the flunders for the test would randomly disappear.

Fixed image path to pick up newly built fixes from this PR.
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 26, 2017
@k8s-github-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abgworrall
We suggest the following additional approver: liggitt

Assign the PR to them by writing /assign @liggitt in a comment when ready.

Associated issue: 53030

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 26, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 26, 2017
@abgworrall abgworrall added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 26, 2017
@abgworrall abgworrall assigned mbohlool and unassigned ixdy Sep 26, 2017
@abgworrall abgworrall added the kind/bug Categorizes issue or PR as related to a bug. label Sep 26, 2017
@abgworrall abgworrall added this to the v1.8 milestone Sep 26, 2017
@abgworrall
Copy link
Copy Markdown
Contributor Author

/retest

@abgworrall
Copy link
Copy Markdown
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@abgworrall abgworrall added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Sep 26, 2017
@abgworrall
Copy link
Copy Markdown
Contributor Author

/retest

@abgworrall abgworrall added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Sep 26, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Sep 27, 2017
@abgworrall
Copy link
Copy Markdown
Contributor Author

Apologies all - I'm removing cherrypick-approval, because it's too close to the release to have the submit queue pushing in code at random times. (The submit queue was wedged for a while yesterday, and didn't drain overnight.)

Once the release is cut, @jpbetz can approve it back into the first patch release.

@jpbetz
Copy link
Copy Markdown
Contributor

jpbetz commented Sep 29, 2017

1.8 is out. Adding cherry-pick-approval back to this PR.

@jpbetz jpbetz added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 29, 2017
@k8s-github-robot k8s-github-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Sep 29, 2017
@liggitt liggitt added the kind/flake Categorizes issue or PR as related to a flaky test. label Sep 29, 2017
@abgworrall
Copy link
Copy Markdown
Contributor Author

/retest

@k8s-github-robot
Copy link
Copy Markdown

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link
Copy Markdown

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit cd89054 into kubernetes:release-1.8 Sep 29, 2017
@k8s-cherrypick-bot
Copy link
Copy Markdown

Commit found in the "release-1.8" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@abgworrall: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-bazel 3bb60c1 link /test pull-kubernetes-e2e-gce-bazel

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants