kubeadm: Add back labels for the Static Pod control plane#50174
kubeadm: Add back labels for the Static Pod control plane#50174k8s-github-robot merged 1 commit intokubernetes:masterfrom
Conversation
139d1b5 to
a69697e
Compare
|
/retest |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: luxas, timothysc No associated issue. Update pull-request body to add a reference to an issue, or get approval with The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue (batch tested with PRs 50254, 50174, 50179) |
|
@luxas: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
…nent_label2 Automatic merge from submit-queue (batch tested with PRs 50893, 50913, 50963, 50629, 50640) kubeadm: Add back labels for the Static Pod control plane (attempt 2) **What this PR does / why we need it**: Exactly the same PR as kubernetes#50174, but that PR was appearently lost in a rebase/mis-merge or something, so resending this one. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` @kubernetes/sig-cluster-lifecycle-pr-reviews
What this PR does / why we need it:
This Labels section has been removed now for a short period during the v1.8 dev cycle, but I found a good use-case for it; namely filtering Mirror Pods by the
component=kube-*label when waiting for the self-hosted control plane to come up after an upgrade. It's not really neccessary, but nice to have.Also noticed the lack of coverage for this func, so added a small unit test.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Dependency for: #48899
Special notes for your reviewer:
Release note:
@kubernetes/sig-cluster-lifecycle-pr-reviews @dmmcquay @timothysc @mattmoyer