Skip to content

kubeadm: Add back labels for the Static Pod control plane (attempt 2)#50963

Merged
k8s-github-robot merged 1 commit intokubernetes:masterfrom
luxas:kubeadm_add_back_component_label2
Aug 22, 2017
Merged

kubeadm: Add back labels for the Static Pod control plane (attempt 2)#50963
k8s-github-robot merged 1 commit intokubernetes:masterfrom
luxas:kubeadm_add_back_component_label2

Conversation

@luxas
Copy link
Copy Markdown
Member

@luxas luxas commented Aug 19, 2017

What this PR does / why we need it:

Exactly the same PR as #50174, but that PR was appearently lost in a rebase/mis-merge or something, so resending this one.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

NONE

@kubernetes/sig-cluster-lifecycle-pr-reviews

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 19, 2017
@luxas luxas added this to the v1.8 milestone Aug 19, 2017
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Aug 19, 2017
@luxas
Copy link
Copy Markdown
Member Author

luxas commented Aug 19, 2017

/approve no-issue

@k8s-github-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: luxas

Associated issue requirement bypassed by: luxas

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2017
@timothysc timothysc added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2017
@k8s-github-robot
Copy link
Copy Markdown

Automatic merge from submit-queue (batch tested with PRs 50893, 50913, 50963, 50629, 50640)

@k8s-github-robot k8s-github-robot merged commit cb1220c into kubernetes:master Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants