StatefulSet: Remove pod.alpha.kubernetes.io/initialized annotation.#49251
StatefulSet: Remove pod.alpha.kubernetes.io/initialized annotation.#49251k8s-github-robot merged 2 commits intokubernetes:masterfrom
pod.alpha.kubernetes.io/initialized annotation.#49251Conversation
|
/test pull-kubernetes-e2e-gce-etcd3 |
kow3ns
left a comment
There was a problem hiding this comment.
This approach is exactly what I had in mind as well. Pausing the StatefulSet, for testing purposes, by breaking its readiness probe achieves the exact same result as the removed annotation without unnecessarily exposing implementation details, and will meet the requirements of backward compatibility.
- Do you intend to cherry pick b8214b2 into 1.7 e2e so that upgrade tests will function?
- Also we should consider removing the annotation from the v1beta2 API.
Both of the above can be addressed in future PRs.
|
/lgtm |
|
/approve |
|
@kow3ns Good points. I've added TODO items to #41605 (comment). |
Instead, use Readiness to pause and resume individual Pods to verify that the StatefulSet controller performs the right actions one at a time.
4122a70 to
283211c
Compare
|
I'm waiting for #49400 before assigning for approval. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enisoc, kow3ns, smarterclayton Associated issue: 41605 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/retest |
|
Automatic merge from submit-queue (batch tested with PRs 48636, 49088, 49251, 49417, 49494) |
The
pod.alpha.kubernetes.io/initializedannotation was originally a tool for validating StatefulSet's ordered Pod creation guarantees during the feature's alpha phase.If set to "false" on a given Pod, it would interrupt StatefulSet's normal behavior. In v1.5.0, the annotation was deprecated and the default became "true" as part of StatefulSet's graduation to beta.
The annotation is now ignored, meaning it cannot be used to interrupt StatefulSet Pod management.
ref #41605