Skip to content

StatefulSet: Remove initialized annotation from apps/v1beta2.#49651

Merged
k8s-github-robot merged 1 commit intokubernetes:masterfrom
enisoc:v1beta2-initialized
Jul 31, 2017
Merged

StatefulSet: Remove initialized annotation from apps/v1beta2.#49651
k8s-github-robot merged 1 commit intokubernetes:masterfrom
enisoc:v1beta2-initialized

Conversation

@enisoc
Copy link
Copy Markdown
Contributor

@enisoc enisoc commented Jul 26, 2017 •
edited
Loading

The annotation was already removed from apps/v1beta1 in #49251, but this copy survived due to another concurrent PR.

ref #41605

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 26, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jul 26, 2017
@enisoc enisoc mentioned this pull request Jul 26, 2017
Closed
@enisoc enisoc added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jul 26, 2017
@janetkuo
Copy link
Copy Markdown
Member

janetkuo commented Jul 27, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2017
@enisoc
Copy link
Copy Markdown
Contributor Author

enisoc commented Jul 31, 2017

/assign @erictune
for API approval.

/retest

@kow3ns
Copy link
Copy Markdown
Member

kow3ns commented Jul 31, 2017

/approve

@kow3ns
Copy link
Copy Markdown
Member

kow3ns commented Jul 31, 2017

/retest

@erictune
Copy link
Copy Markdown
Contributor

erictune commented Jul 31, 2017

/lgtm

@erictune
Copy link
Copy Markdown
Contributor

erictune commented Jul 31, 2017

/approve

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Jul 31, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enisoc, erictune, janetkuo, kow3ns

Associated issue: 49251

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2017
@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Jul 31, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Jul 31, 2017

Automatic merge from submit-queue (batch tested with PRs 49651, 49707, 49662, 47019, 49747)

@k8s-github-robot k8s-github-robot merged commit 0acb503 into kubernetes:master Jul 31, 2017
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 1, 2017 •
edited
Loading

@enisoc: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-etcd3 75ee3e0 link /test pull-kubernetes-e2e-gce-etcd3

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@enisoc enisoc deleted the v1beta2-initialized branch August 23, 2017 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@janetkuo janetkuo janetkuo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@janetkuo janetkuo

@erictune erictune

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@enisoc @janetkuo @kow3ns @erictune @k8s-github-robot @k8s-ci-robot