Skip to content

Use a different env var to enable the ip-masq-agent addon.#47993

Merged
k8s-github-robot merged 1 commit intokubernetes:masterfrom
dnardo:ip-masq-agent
Jun 24, 2017
Merged

Use a different env var to enable the ip-masq-agent addon.#47993
k8s-github-robot merged 1 commit intokubernetes:masterfrom
dnardo:ip-masq-agent

Conversation

@dnardo
Copy link
Copy Markdown
Contributor

@dnardo dnardo commented Jun 23, 2017

We shouldn't mix setting the non-masq-cidr with enabling the addon.

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

#47865

We shouldn't mix setting the non-masq-cidr with enabling the addon.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 23, 2017
@dnardo
Copy link
Copy Markdown
Contributor Author

dnardo commented Jun 23, 2017

/assign @freehan

@dnardo
Copy link
Copy Markdown
Contributor Author

dnardo commented Jun 23, 2017

/assign @dchen1107

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jun 23, 2017
@dchen1107 dchen1107 added this to the v1.7 milestone Jun 23, 2017
@dchen1107 dchen1107 added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jun 23, 2017
@dchen1107
Copy link
Copy Markdown
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2017
@dchen1107 dchen1107 added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate labels Jun 23, 2017
@k8s-github-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, dnardo

Associated issue: 47865

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2017
@k8s-github-robot
Copy link
Copy Markdown

Automatic merge from submit-queue (batch tested with PRs 47993, 47892, 47591, 47469, 47845)

@k8s-github-robot k8s-github-robot merged commit de86a83 into kubernetes:master Jun 24, 2017
k8s-github-robot pushed a commit that referenced this pull request Jun 27, 2017
…#47986-#47152-#47860-#47945-#47961-#47986-#47993-#48012-#48085-upstream-release-1.7

Automatic merge from submit-queue

Automated cherry pick of #47986 #47152 #47860 #47945 #47961 #47986 #47993 #48012 #48085

Cherry pick of #47986 #47152 #47860 #47945 #47961 #47986 #47993 #48012 #48085 on release-1.7.

#47986: Change service port to avoid collision
#47152: Kubelet doesn't override addrs from Cloud provider
#47860: Make fluentd log to stdio instead of a dedicated file
#47945: add level for print flags
#47961: Bumped Heapster to v1.4.0-beta.0
#47986: Change service port to avoid collision
#47993: Use a different env var to enable the ip-masq-agent addon. We
#48012: Extending timeout waiting for delete node to become ready
#48085: Move iptables logging in kubeproxy from Errorf to V(2).Infof
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants