Skip to content

add level for print flags#47945

Merged
k8s-github-robot merged 1 commit intokubernetes:masterfrom
sakeven:fix/add_level_for_print_flags
Jun 23, 2017
Merged

add level for print flags#47945
k8s-github-robot merged 1 commit intokubernetes:masterfrom
sakeven:fix/add_level_for_print_flags

Conversation

@sakeven
Copy link
Copy Markdown
Contributor

@sakeven sakeven commented Jun 23, 2017 •
edited
Loading

Signed-off-by: sakeven jc5930@sina.cn

What this PR does / why we need it:
It's ugly to print all flags whenever.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):

fixes #47932

Special notes for your reviewer:

Release note:

NONE

@sakeven
add level for print flags
8b1a08a 
Signed-off-by: sakeven <jc5930@sina.cn>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 23, 2017
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jun 23, 2017

Hi @sakeven. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 23, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jun 23, 2017
@cblecker
Copy link
Copy Markdown
Member

cblecker commented Jun 23, 2017

/ok-to-test
/release-note-none

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 23, 2017
@Random-Liu Random-Liu added this to the v1.7 milestone Jun 23, 2017
@Random-Liu
Copy link
Copy Markdown
Member

Random-Liu commented Jun 23, 2017

/cc @kubernetes/kubernetes-release-managers Mark 1.7 because this fixes a 1.7 issue #47932.

@sakeven
Copy link
Copy Markdown
Contributor Author

sakeven commented Jun 23, 2017

/retest

@CaoShuFeng
Copy link
Copy Markdown
Contributor

CaoShuFeng commented Jun 23, 2017

test OK in my environment.

@dchen1107 dchen1107 added cherrypick-candidate cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Jun 23, 2017
@dchen1107
Copy link
Copy Markdown
Member

dchen1107 commented Jun 23, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2017
@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Jun 23, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, sakeven

Associated issue: 47932

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2017
@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Jun 23, 2017

Automatic merge from submit-queue (batch tested with PRs 47883, 47179, 46966, 47982, 47945)

@k8s-github-robot k8s-github-robot merged commit 1a93dd6 into kubernetes:master Jun 23, 2017
@sakeven sakeven deleted the fix/add_level_for_print_flags branch June 24, 2017 05:04
@shiywang shiywang mentioned this pull request Jun 25, 2017
Closed
@caesarxuchao caesarxuchao mentioned this pull request Jun 27, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Jun 27, 2017
Merge pull request #48146 from caesarxuchao/automated-cherry-pick-of-…
625cfe5 
…#47986-#47152-#47860-#47945-#47961-#47986-#47993-#48012-#48085-upstream-release-1.7

Automatic merge from submit-queue

Automated cherry pick of #47986 #47152 #47860 #47945 #47961 #47986 #47993 #48012 #48085

Cherry pick of #47986 #47152 #47860 #47945 #47961 #47986 #47993 #48012 #48085 on release-1.7.

#47986: Change service port to avoid collision
#47152: Kubelet doesn't override addrs from Cloud provider
#47860: Make fluentd log to stdio instead of a dedicated file
#47945: add level for print flags
#47961: Bumped Heapster to v1.4.0-beta.0
#47986: Change service port to avoid collision
#47993: Use a different env var to enable the ip-masq-agent addon. We
#48012: Extending timeout waiting for delete node to become ready
#48085: Move iptables logging in kubeproxy from Errorf to V(2).Infof
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ncdc ncdc

@lavalamp lavalamp

@dchen1107 dchen1107

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.7

Development

Successfully merging this pull request may close these issues.

kubelet --version should not print all the flags

10 participants

@sakeven @k8s-ci-robot @cblecker @Random-Liu @CaoShuFeng @dchen1107 @k8s-github-robot @ncdc @lavalamp @caesarxuchao