disable GC for custom resources#47432
Merged
k8s-github-robot merged 1 commit intokubernetes:masterfrom Jun 15, 2017
Merged
Conversation
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, enisoc Associated issue: 47431 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:You can indicate your approval by writing |
Contributor
Author
|
@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this |
sttts
reviewed
Jun 13, 2017
| DefaultWatchCacheSize: etcdOptions.DefaultWatchCacheSize, | ||
| // garbage collection for custom resources is forced off until GC works with CRs. | ||
| // When GC is enabled, this turns back into etcdOptions.EnableGarbageCollection | ||
| EnableGarbageCollection: false, |
Contributor
Author
|
@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this |
1 similar comment
Contributor
|
@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this |
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
|
Automatic merge from submit-queue (batch tested with PRs 47204, 46808, 47432, 47400, 47099) |
k8s-github-robot
pushed a commit
that referenced
this pull request
Jul 29, 2017
Automatic merge from submit-queue (batch tested with PRs 49538, 49708, 47665, 49750, 49528) Enable garbage collection of custom resources Enhance the garbage collector to periodically refresh the resources it monitors (via discovery) to enable custom resource definition GC (addressing #44507 and reverting #47432). This is a replacement for #46000. /cc @lavalamp @deads2k @sttts @caesarxuchao /ref #48065 ```release-note The garbage collector now supports custom APIs added via CustomeResourceDefinition or aggregated apiservers. Note that the garbage collector controller refreshes periodically, so there is a latency between when the API is added and when the garbage collector starts to manage it. ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xref #47431
This prevents GC on CustomResources so you don't get an uncleared finalizer that prevents deletion