Skip to content

CRD: Test delete both with and without cascading.#47451

Merged
k8s-github-robot merged 1 commit intokubernetes:masterfrom
enisoc:crd-orphan-finalizer
Jun 16, 2017
Merged

CRD: Test delete both with and without cascading.#47451
k8s-github-robot merged 1 commit intokubernetes:masterfrom
enisoc:crd-orphan-finalizer

Conversation

@enisoc
Copy link
Copy Markdown
Contributor

@enisoc enisoc commented Jun 13, 2017

Fixes #47431

Depends on #47432 (included for now; will rebase if needed)

@enisoc enisoc added release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jun 13, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 13, 2017
@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 13, 2017
@enisoc enisoc added this to the v1.7 milestone Jun 13, 2017
@sttts
Copy link
Copy Markdown
Contributor

sttts commented Jun 14, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2017
@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Jun 14, 2017

/approve

@k8s-github-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, enisoc, sttts

Associated issue: 47431

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2017
@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Jun 14, 2017

/retest

1 similar comment
@enisoc
Copy link
Copy Markdown
Contributor Author

enisoc commented Jun 14, 2017

/retest

@enisoc enisoc force-pushed the crd-orphan-finalizer branch from cb96feb to 7b985f5 Compare June 15, 2017 03:05
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 15, 2017
@enisoc enisoc added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2017
@enisoc
Copy link
Copy Markdown
Contributor Author

enisoc commented Jun 15, 2017

/retest

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 15, 2017
@enisoc
Copy link
Copy Markdown
Contributor Author

enisoc commented Jun 15, 2017

I created a merge conflict with myself. :(

@enisoc enisoc force-pushed the crd-orphan-finalizer branch from 7b985f5 to 394c6a5 Compare June 15, 2017 05:37
@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 15, 2017
@enisoc enisoc added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2017
@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Jun 15, 2017

/retest

2 similar comments
@enisoc
Copy link
Copy Markdown
Contributor Author

enisoc commented Jun 15, 2017

/retest

@enisoc
Copy link
Copy Markdown
Contributor Author

enisoc commented Jun 16, 2017

/retest

@k8s-github-robot
Copy link
Copy Markdown

Automatic merge from submit-queue (batch tested with PRs 47451, 47410, 47598, 47616, 47473)

@k8s-github-robot k8s-github-robot merged commit a56af86 into kubernetes:master Jun 16, 2017
@enisoc enisoc deleted the crd-orphan-finalizer branch June 28, 2017 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants