Skip to content

Alphabetize kubectl resource shortcuts list#18268

Merged
k8s-github-robot merged 1 commit intokubernetes:masterfrom
tmrts:sort/constants
Dec 9, 2015
Merged

Alphabetize kubectl resource shortcuts list#18268
k8s-github-robot merged 1 commit intokubernetes:masterfrom
tmrts:sort/constants

Conversation

@tmrts
Copy link
Copy Markdown
Contributor

@tmrts tmrts commented Dec 7, 2015

Sorted strings.

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Dec 7, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

1 similar comment
@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Dec 7, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@k8s-github-robot
Copy link
Copy Markdown

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 7, 2015
@j3ffml
Copy link
Copy Markdown
Contributor

j3ffml commented Dec 7, 2015

lgtm, thanks.

@j3ffml j3ffml added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-merge labels Dec 7, 2015
@k8s-github-robot
Copy link
Copy Markdown

@k8s-bot ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Dec 7, 2015

GCE e2e test build/test passed for commit 5ac372d.

@k8s-github-robot
Copy link
Copy Markdown

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Dec 9, 2015
@k8s-github-robot k8s-github-robot merged commit f525c2e into kubernetes:master Dec 9, 2015
@tmrts tmrts deleted the sort/constants branch December 13, 2015 15:46
openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Feb 27, 2018
Automatic merge from submit-queue (batch tested with PRs 18415, 18419, 18268, 18102, 18440).

UPSTREAM: 58753: Fix kubectl explain for cronjobs

Fixes kubernetes#18261.

@Kargakis fyi
/assign @juanvallejo

Origin-commit: 797fbdec73a8959129a95be7bfdb0e3d53d18d45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants