Node affinity and NodeSelector design doc by davidopp · Pull Request #18261 · kubernetes/kubernetes

davidopp · 2015-12-06T22:32:22Z

Ref/ #341

@bgrant0607 @soltysh @sdminonne @mikedanese @derekwaynecarr @kevin-wangzefeng @ravigadde @timothysc

k8s-github-robot · 2015-12-06T22:40:30Z

Labelling this PR as size/L

k8s-bot · 2015-12-06T23:04:10Z

GCE e2e test build/test passed for commit 974392ea8b82b4f0c0772877a886caf948701663.

k8s-bot · 2015-12-07T01:00:39Z

GCE e2e build/test failed for commit 0f952fd863d82c9bfccb1562e347b45f452e4fd0.

k8s-bot · 2015-12-07T01:34:36Z

GCE e2e build/test failed for commit d1bf70e40d5592deb626cc7172210a3359ed7850.

k8s-bot · 2015-12-07T08:28:14Z

GCE e2e build/test failed for commit 84ec093b8ba7a7c1f8f316b7d401382b48892f98.

davidopp · 2015-12-07T20:19:15Z

@quinton-hoole this is relevant to both flavors of Ubernetes

sdminonne · 2015-12-07T21:39:27Z

docs/proposals/nodeselector.md

s/PodSelector/LabelSelector/

davidopp · 2015-12-08T05:04:41Z

Comments from meeting with @bgrant0607 today follow. I will update the proposal to reflect them shortly:

Make it clear that Kubelet should enforce constraints (not just scheduler); goes into shared predicate library between kubelet and scheduler
Should tell users not to use these features until they have been in Kubelet and master for enough binary versions that we feel comfortable we will not need to roll back either to a version that does not support them; longer-term would be good to have a way to enforce this (Cluster versioning #4855)

soltysh · 2015-12-08T13:59:48Z

docs/proposals/nodeselector.md

I'd suggest sticking to what we have with generalized selectors, iow. empty - selects every object in the collection; null - selects no objects.

k8s-github-robot · 2016-01-24T02:15:04Z

PR changed after LGTM, removing LGTM.

k8s-github-robot · 2016-01-24T02:35:02Z

PR changed after LGTM, removing LGTM.

k8s-bot · 2016-01-24T03:04:58Z

GCE e2e test build/test passed for commit a5dee8655f28f6fb74e9f7f9bcec1774cd9c6397.

k8s-bot · 2016-01-24T03:07:53Z

GCE e2e test build/test passed for commit d306ee88f064ffa7204faab6e030273ec04956dc.

k8s-bot · 2016-01-24T03:12:29Z

GCE e2e test build/test passed for commit f09d1c7405d4939f7dda67452d11561817ba882b.

k8s-github-robot · 2016-01-24T04:05:01Z

PR changed after LGTM, removing LGTM.

k8s-bot · 2016-01-24T04:30:51Z

GCE e2e test build/test passed for commit 32fa440.

davidopp · 2016-01-24T20:12:41Z

Tests pass, manually merging as this is a doc-only PR with just one doc.

Node affinity and NodeSelector design doc

Automatic merge from submit-queue selector: make sure value of GT and LT is integer GT and LT in selector has been introduced in Node Affinity feature: #19758, #18261 According to the API: > If the operator is Gt or Lt, the values array must have a single element, which will be interpreted as an integer. But the implementation has parsed it as float64: https://github.com/kubernetes/kubernetes/blob/ef0c9f0c5b8efbba948a0be2c98d9d2e32e0b68c/pkg/labels/selector.go#L183 Modeling integer as float is dangerous. We don't even have fixed precision guarantee when doing comparison. This PR is to get rid of this pre-optimization and convert **integer** to int64.

@Kargakis

Automatic merge from submit-queue (batch tested with PRs 18415, 18419, 18268, 18102, 18440). UPSTREAM: 58753: Fix kubectl explain for cronjobs Fixes kubernetes#18261. @Kargakis fyi /assign @juanvallejo Origin-commit: 797fbdec73a8959129a95be7bfdb0e3d53d18d45

davidopp assigned bgrant0607 Dec 6, 2015

googlebot added the cla: yes label Dec 6, 2015

k8s-github-robot added kind/design Categorizes issue or PR as related to design. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 6, 2015

davidopp mentioned this pull request Dec 6, 2015

Dedicated nodes, taints, and tolerations design proposal #18263

Merged

davidopp mentioned this pull request Dec 6, 2015

Inter-pod topological affinity/anti-affinity proposal #18265

Merged

davidopp force-pushed the nodeselector branch 3 times, most recently from 0f952fd to d1bf70e Compare December 7, 2015 00:32

davidopp changed the title ~~NodeSelector, NodeConstraints, NodePreferences proposal initial draft.~~ NodeSelector, NodeConstraints, NodePreferences proposal Dec 7, 2015

This was referenced Dec 7, 2015

More general scheduling constraints #367

Closed

Preference/optional form of PodSpec.NodeSelector #8008

Closed

davidopp force-pushed the nodeselector branch from d1bf70e to 84ec093 Compare December 7, 2015 07:26

sdminonne reviewed Dec 7, 2015
View reviewed changes

docs/proposals/nodeselector.md Outdated

Copy link
Copy Markdown

Contributor

sdminonne Dec 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/PodSelector/LabelSelector/

bgrant0607 mentioned this pull request Dec 8, 2015

Proposal: Forgiveness #1574

Closed

soltysh reviewed Dec 8, 2015
View reviewed changes

bgrant0607 added lgtm "Looks good to me", indicates that a PR is ready to be merged. e2e-not-required labels Jan 22, 2016

k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2016

davidopp force-pushed the nodeselector branch from a5dee86 to f09d1c7 Compare January 24, 2016 02:24

davidopp added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2016

davidopp force-pushed the nodeselector branch from f09d1c7 to d306ee8 Compare January 24, 2016 02:34

k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. kind/design Categorizes issue or PR as related to design. labels Jan 24, 2016

davidopp added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2016

davidopp changed the title ~~NodeSelector, NodeConstraints, NodePreferences proposal~~ Node affinity and NodeSelector design doc Jan 24, 2016

Design doc for node affinity, including NodeSelector.

32fa440

davidopp force-pushed the nodeselector branch from d306ee8 to 32fa440 Compare January 24, 2016 03:58

k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2016

davidopp added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2016

davidopp pushed a commit that referenced this pull request Jan 24, 2016

Merge pull request #18261 from davidopp/nodeselector

1948dc5

Node affinity and NodeSelector design doc

davidopp merged commit 1948dc5 into kubernetes:master Jan 24, 2016

davidopp mentioned this pull request May 8, 2016

Requirements for Affinity to graduate to Beta and then v1 #25319

Open

9 tasks

hongchaodeng mentioned this pull request Jul 4, 2016

selector: make sure value of GT and LT is integer #28474

Merged

davidopp mentioned this pull request Oct 1, 2016

Node affinity kubernetes/enhancements#106

Closed

23 tasks

Conversation

davidopp commented Dec 6, 2015

Uh oh!

k8s-github-robot commented Dec 6, 2015

Uh oh!

k8s-bot commented Dec 6, 2015

Uh oh!

k8s-bot commented Dec 7, 2015

Uh oh!

k8s-bot commented Dec 7, 2015

Uh oh!

k8s-bot commented Dec 7, 2015

Uh oh!

davidopp commented Dec 7, 2015

Uh oh!

sdminonne Dec 7, 2015

Choose a reason for hiding this comment

Uh oh!

davidopp commented Dec 8, 2015

Uh oh!

soltysh Dec 8, 2015

Choose a reason for hiding this comment

Uh oh!

k8s-github-robot commented Jan 24, 2016

Uh oh!

k8s-github-robot commented Jan 24, 2016

Uh oh!

k8s-bot commented Jan 24, 2016

Uh oh!

k8s-bot commented Jan 24, 2016

Uh oh!

k8s-bot commented Jan 24, 2016

Uh oh!

k8s-github-robot commented Jan 24, 2016

Uh oh!

k8s-bot commented Jan 24, 2016

Uh oh!

davidopp commented Jan 24, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants