Skip to content

Revert "Add random interval to nodeStatusReport interval every time after an actual node status change"#130348

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
aojea:revert-128640-spreadkubeletlaod
Feb 21, 2025
Merged

Revert "Add random interval to nodeStatusReport interval every time after an actual node status change"#130348
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
aojea:revert-128640-spreadkubeletlaod

Conversation

@aojea

@aojea aojea commented Feb 21, 2025

Copy link
Copy Markdown
Member

Reverts #128640

https://github.com/kubernetes/kubernetes/pull/128640/files#r1965695110

This added a change behavior that regressed the kubelet #130305 @mengqiy @SergeyKanzhelev

The devil is in the details , before

shouldPatchNodeStatus := changed || kl.clock.Since(kl.lastStatusReportTime) >= kl.nodeStatusReportFrequency

but kl.clock.Since(kl.lastStatusReportTime) >= kl.nodeStatusReportFrequency if kl.lastStatusReportTime is time.Time{} or time.Zero is always true time.Since(time.Time{})

and in this patch we changed this meaning , so before it always updated the status after start but now , if there are no changes, it will never update the status

@liggitt is recommending to revert , and backport the revert so we can rework it in the current branch

#130305 (comment)

and I agree with him, after seeing the issue in #130001 and all the indirect dependencies associated to the status update we can not be sure that fix forwarding we don't find a new weird bug, this took @lentzi90 a lot of work to figure it out, who could imagine that the certificate creation was dependong on the node status update

Fixes: #130001

/kind bug
/kind regression

Fixes a 1.32 regression where nodes may fail to report status and renew serving certificates after the kubelet restarts

/assign @dims @liggitt
/sig node

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/regression Categorizes issue or PR as related to a regression from a prior release. sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet labels Feb 21, 2025
@liggitt

liggitt commented Feb 21, 2025

Copy link
Copy Markdown
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2025
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 137f19ce6e5e8808bd1cb7d7d064adafb83f992c

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2025
@dims

dims commented Feb 21, 2025

Copy link
Copy Markdown
Member

thanks for digging deep into this @lentzi90 !!

/approve
/lgtm
/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 21, 2025
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims

dims commented Feb 21, 2025

Copy link
Copy Markdown
Member

/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 21, 2025
@k8s-ci-robot k8s-ci-robot merged commit 6025e23 into kubernetes:master Feb 21, 2025
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Feb 21, 2025
k8s-ci-robot added a commit that referenced this pull request Feb 25, 2025
…8-upstream-release-1.32

Automated cherry pick of #130348: Revert "Add random interval to nodeStatusReport interval every time after an actual node status change"
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

Development

Successfully merging this pull request may close these issues.

Kubelet serving CSR never created

4 participants