Skip to content

Automated cherry pick of #130348: Revert "Add random interval to nodeStatusReport interval every time after an actual node status change"#130356

Merged
k8s-ci-robot merged 1 commit into
kubernetes:release-1.32from
aojea:automated-cherry-pick-of-#130348-upstream-release-1.32
Feb 25, 2025
Merged

Automated cherry pick of #130348: Revert "Add random interval to nodeStatusReport interval every time after an actual node status change"#130356
k8s-ci-robot merged 1 commit into
kubernetes:release-1.32from
aojea:automated-cherry-pick-of-#130348-upstream-release-1.32

Conversation

@aojea

@aojea aojea commented Feb 21, 2025 •
edited by liggitt
Loading

Copy link
Copy Markdown
Member

Cherry pick of #130348 on release-1.32.

#130348: Revert "Add random interval to nodeStatusReport interval every time after an actual node status change"

For details on the cherry pick process, see the cherry pick requests page.

Fixes a 1.32 regression where nodes may fail to report status and renew serving certificates after the kubelet restarts

/kind bug
/kind regressions

@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Feb 21, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 21, 2025
@k8s-ci-robot

k8s-ci-robot commented Feb 21, 2025

Copy link
Copy Markdown
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Feb 21, 2025
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 21, 2025
@aojea

aojea commented Feb 21, 2025

Copy link
Copy Markdown
Member Author

/assign @liggitt @dims

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 21, 2025
@liggitt

liggitt commented Feb 22, 2025

Copy link
Copy Markdown
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2025
@k8s-ci-robot

k8s-ci-robot commented Feb 22, 2025

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: d0697cd9f226c060f977f4d6d3ecdea97f9718fd

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2025
@liggitt

liggitt commented Feb 22, 2025

Copy link
Copy Markdown
Member

/retest
Cc @kubernetes/release-managers

cpanato
cpanato approved these changes Feb 24, 2025
View reviewed changes

@cpanato cpanato left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Feb 24, 2025
@k8s-ci-robot

k8s-ci-robot commented Feb 24, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, cpanato, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

liggitt commented Feb 24, 2025

Copy link
Copy Markdown
Member

/kind regression
/kind bug

@k8s-ci-robot k8s-ci-robot added kind/regression Categorizes issue or PR as related to a regression from a prior release. kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Feb 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit 85ff792 into kubernetes:release-1.32 Feb 25, 2025
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpanato cpanato cpanato approved these changes

@kannon92 kannon92 Awaiting requested review from kannon92

@odinuge odinuge Awaiting requested review from odinuge

Assignees

@dims dims

@liggitt liggitt

@cpanato cpanato

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

SIG Node: code and documentation PRs
Archived in project

Milestone

v1.32

Development

Successfully merging this pull request may close these issues.

5 participants

@aojea @k8s-ci-robot @liggitt @cpanato @dims