Promote RetryGenerateName to GA by jpbetz · Pull Request #127093 · kubernetes/kubernetes

jpbetz · 2024-09-03T14:51:27Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Special notes for your reviewer:

Do we want the retry_for_generate_name metric originally proposed for GA? Looking at the adjacent labels for request metrics ("verb", "dry_run", "group", "version", "resource", "subresource", "scope", "component", "code"), this feels somewhat out-of-place..

Does this PR introduce a user-facing change?

Promoted `RetryGenerateName` to stable; the feature is enabled by default. `--feature-gates=RetryGenerateName=true` not needed on kube-apiserver binaries and will be removed in a future release.

jpbetz · 2024-09-03T14:53:12Z

/sig api-machinery

jpbetz · 2024-09-03T14:57:44Z

@aaron-prindle Just a heads up that this might collide with your feature migration. I'm happy to merge after your PR and re-base.

jpbetz · 2024-09-03T14:58:58Z

/assign @deads2k
See description for a question about if we want a metric for this or not.

Jefftree · 2024-09-03T16:19:39Z

Ah this is one of the more involved features to port that involves a definition both in kube_features and apiserver/pkg/kube_features. I think we should consolidate the names so only one variable (

kubernetes/staging/src/k8s.io/apiserver/pkg/features/kube_features.go

Lines 203 to 207 in f1664b0

    
           // owner: @jpbetz 
        
           // alpha: v1.30 
        
           // Resource create requests using generateName are retried automatically by the apiserver 
        
           // if the generated name conflicts with an existing resource name, up to a maximum number of 7 retries. 
        
           RetryGenerateName featuregate.Feature = "RetryGenerateName"

) is referenced.

Also, 1.32 feature promotion depends on #126977 to land.

Jefftree · 2024-09-03T20:12:22Z

/triage accepted

jpbetz · 2024-09-10T17:30:26Z

Ah this is one of the more involved features to port that involves a definition both in kube_features and apiserver/pkg/kube_features. I think we should consolidate the names so only one variable

I'm okay with this change, but shouldn't it be applied uniformly to all of apiserver/pkg/kube_features, not piecemeal? Should that be the responsibility of feature owners?

Jefftree · 2024-09-10T17:45:12Z

Ah this is one of the more involved features to port that involves a definition both in kube_features and apiserver/pkg/kube_features. I think we should consolidate the names so only one variable

I'm okay with this change, but shouldn't it be applied uniformly to all of apiserver/pkg/kube_features, not piecemeal? Should that be the responsibility of feature owners?

Most apiserver features are already deduplicated and kube_features imports directly from apiserver/pkg/kube_features. #127186 this PR fixes it for RetryGenerateName

Jefftree · 2024-09-18T16:50:44Z

@jpbetz CI should work properly after a rebase now that we've bumped compatibility version to 1.32

jpbetz · 2024-09-19T13:40:37Z

CI should work properly after a rebase now that we've bumped compatibility version to 1.32

Great, I've rebased.

jpbetz · 2024-09-19T16:37:09Z

 	// owner: @jpbetz
 	// alpha: v1.30
 	// beta: v1.31
+	// ga: v1.32


nit: These stability level comments feel unnecessary for versioned feature gates. Worse, there is a risk that these comments will fall out of sync with the versioned feature gate information. We might consider removing these once fully migrated.

yeah I'm +1 on removing these after we have everything ported. We already found quite a few inaccuracies with the comments

Jefftree

LGTM

Jefftree · 2024-09-23T17:39:11Z

/lgtm
/approve

Feature is targeted for GA in 1.32 kubernetes/enhancements#4420

k8s-ci-robot · 2024-09-23T17:39:17Z

LGTM label has been added.

Details

Git tree hash: 7f73e7e9599312435c63113fcfe7dc5442d91dc5

k8s-ci-robot · 2024-09-23T17:39:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jefftree, jpbetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~pkg/features/OWNERS~~ [jpbetz]
~~staging/src/k8s.io/apiserver/OWNERS~~ [jpbetz]
~~test/featuregates_linter/test_data/OWNERS~~ [jpbetz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-triage-robot · 2024-09-23T21:51:22Z

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

The PR does have any do-not-merge/* labels
The PR does not have the needs-ok-to-test label
The PR is mergeable (does not have a needs-rebase label)
The PR is approved (has cncf-cla: yes, lgtm, approved labels)
The PR is failing tests required for merge

You can:

Review the full test history for this PR
Prevent this bot from retesting with /lgtm cancel or /hold
Help make our tests less flaky by following our Flaky Tests Guide

/retest

tengqm · 2024-09-25T04:16:03Z

Please propose a PR to the website for this promotion.

k8s-ci-robot requested review from dims and tkashem September 3, 2024 14:51

jpbetz mentioned this pull request Sep 3, 2024

Promote RetryGenerateName to GA in 1.32 kubernetes/website#47770

Merged

jpbetz mentioned this pull request Sep 3, 2024

Retry Generate Name kubernetes/enhancements#4420

Closed

12 tasks

k8s-ci-robot assigned deads2k Sep 3, 2024

k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 3, 2024

jpbetz force-pushed the retry-generate-name-ga branch from f1664b0 to d5db629 Compare September 10, 2024 16:34

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2024

jpbetz force-pushed the retry-generate-name-ga branch from d5db629 to 4e50d07 Compare September 19, 2024 13:40

jpbetz force-pushed the retry-generate-name-ga branch from 4e50d07 to 781e8d3 Compare September 19, 2024 14:45

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 19, 2024

jpbetz force-pushed the retry-generate-name-ga branch 2 times, most recently from 759bc53 to c2dc5d5 Compare September 19, 2024 16:00

jpbetz commented Sep 19, 2024

View reviewed changes

Comment thread staging/src/k8s.io/apiserver/pkg/features/kube_features.go

jpbetz commented Sep 19, 2024

View reviewed changes

Jefftree reviewed Sep 19, 2024

View reviewed changes

Comment thread staging/src/k8s.io/apiserver/pkg/features/kube_features.go

jpbetz added 2 commits September 19, 2024 14:01

Promote RetryGenerateName to GA

e3cae09

Preserve testing of RetryGenerateName feature disablement

0d14bac

jpbetz force-pushed the retry-generate-name-ga branch from f38f106 to 0d14bac Compare September 19, 2024 18:02

Jefftree reviewed Sep 23, 2024

View reviewed changes

k8s-ci-robot assigned Jefftree Sep 23, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2024

k8s-ci-robot merged commit 1137a6a into kubernetes:master Sep 23, 2024

k8s-ci-robot added this to the v1.32 milestone Sep 23, 2024

kaovilai mentioned this pull request Oct 22, 2025

fix: use PVC name instead of GenerateName for VMFR restores openshift/openshift-velero-plugin#359

Closed

coderabbitai Bot mentioned this pull request Apr 30, 2026

fix: trust gate hardening — dead fields, audit retry, TrustLevelRank safety agent-control-plane/aip-k8s#164

Merged

5 tasks

Conversation

jpbetz commented Sep 3, 2024

What type of PR is this?

What this PR does / why we need it:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

jpbetz commented Sep 3, 2024

Uh oh!

jpbetz commented Sep 3, 2024

Uh oh!

jpbetz commented Sep 3, 2024

Uh oh!

Jefftree commented Sep 3, 2024

Uh oh!

Jefftree commented Sep 3, 2024

Uh oh!

jpbetz commented Sep 10, 2024

Uh oh!

Jefftree commented Sep 10, 2024

Uh oh!

Jefftree commented Sep 18, 2024

Uh oh!

jpbetz commented Sep 19, 2024

Uh oh!

Uh oh!

jpbetz Sep 19, 2024

Choose a reason for hiding this comment

Uh oh!

Jefftree Sep 23, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Jefftree left a comment

Choose a reason for hiding this comment

Uh oh!

Jefftree commented Sep 23, 2024

Uh oh!

k8s-ci-robot commented Sep 23, 2024

Uh oh!

k8s-ci-robot commented Sep 23, 2024

Uh oh!

k8s-triage-robot commented Sep 23, 2024

Uh oh!

tengqm commented Sep 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants