Hi @aaron-prindle. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

/ok-to-test

/triage accepted

Currently the integration tests fail without the 1beta3 flowcontrols changes to add a prerelease-lifecycle-gen:removed=1.33 tag. Without these changes, the following tests fail:

Failed job history:
link:
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/126977/pull-kubernetes-integration/1834653846241021952
tests:

• k8s.io/kubernetes/test/integration/controlplane: transformation
• k8s.io/kubernetes/test/integration: etcd
• k8s.io/kubernetes/test/integration: metrics

I've re-added the prerelease-lifecycle-gen:removed=1.33 tag to v1beta3 flowcontrol types.go + updated a related /usr/local/google/home/aprindle/kubernetes/test/integration/apiserver/apiserver_test.go which relies on the version v1beta3 flowcontrol is removed at to the PR to get tests passing again:

Additional changes made related to v1beta3 flowcontrol APIs to get tests green:

• ed94223
• 40f843f

I still trying to understand what alternative fixes there might be here, currently ommitting any v1beta3 flowcontrol change causes integration tests to fail. I understand that no beta API should have to be modified but it seems that v1beta3 flowcontrol being removed @ 1.32 directly relates to the integration tests failing atm

I've re-added the prerelease-lifecycle-gen:removed=1.33 tag to v1beta3 flowcontrol types.go + updated a related /usr/local/google/home/aprindle/kubernetes/test/integration/apiserver/apiserver_test.go which relies on the version v1beta3 flowcontrol is removed at to the PR to get tests passing again:

we're not going to push out removal of v1beta3, so let's keep it at 1.32 and work through the test failures

I think the expectation is that once we remove the ability to serve something, we drop it from test/integration/etcd/data.go

I think that means for v1beta3 flowcontrol in 1.32 we can either:

1. drop v1beta3 flowcontrol from the etcd test data now (since we're bumping to 1.32 and by default we won't serve it any more)
2. set KUBE_APISERVER_SERVE_REMOVED_APIS_FOR_ONE_RELEASE=true in the integration tests to let things technically past their removal minor but which still actually have serving code wired up still be served. Then when we actually remove serving code for v1beta3 flowcontrol in 1.33 we'll drop it from etcd test data

I'd lean towards the latter

As discussed offline, selected the preferred option below to resolve v1beta3 flowcontrol integration test failures:

set KUBE_APISERVER_SERVE_REMOVED_APIS_FOR_ONE_RELEASE=true in the integration tests to let things technically past their removal minor but which still actually have serving code wired up still be served. Then when we actually remove serving code for v1beta3 flowcontrol in 1.33 we'll drop it from etcd test data

With that change in, the tests are passing now 🟢

Going to squash the commits now and resubmit

Tests green now 🟢. Thanks for all of the help here @liggitt!

/lgtm
/approve

LGTM label has been added.

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aaron-prindle, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here