Skip to content

remove the feature flag duplicate definition from pkg/features/kube_features.go #127186

Merged
k8s-ci-robot merged 2 commits into
kubernetes:masterfrom
Adarsh-verma-14:remove-duplication
Sep 10, 2024
Merged

remove the feature flag duplicate definition from pkg/features/kube_features.go #127186
k8s-ci-robot merged 2 commits into
kubernetes:masterfrom
Adarsh-verma-14:remove-duplication

Conversation

@Adarsh-verma-14

@Adarsh-verma-14 Adarsh-verma-14 commented Sep 6, 2024

Copy link
Copy Markdown

remove the feature flag duplicate definition from pkg/features/kube_features.go for RetryGenerateName

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

remove the feature flag duplicate definition

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

NONE

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 6, 2024
@k8s-ci-robot

k8s-ci-robot commented Sep 6, 2024

Copy link
Copy Markdown
Contributor

Hi @Adarsh-verma-14. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot requested review from dims and thockin September 6, 2024 06:47
@Adarsh-verma-14

Adarsh-verma-14 commented Sep 6, 2024

Copy link
Copy Markdown
Author

Fixes #127160

@Adarsh-verma-14

Adarsh-verma-14 commented Sep 6, 2024

Copy link
Copy Markdown
Author

Also Part of #126926

@Jefftree

Jefftree commented Sep 6, 2024

Copy link
Copy Markdown
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 6, 2024
Jefftree
Jefftree reviewed Sep 6, 2024
View reviewed changes
Comment thread pkg/features/kube_features.go Outdated
@Jefftree

Jefftree commented Sep 6, 2024

Copy link
Copy Markdown
Member

/sig api-machinery
/triage accepted

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 6, 2024
@Jefftree

Jefftree commented Sep 6, 2024

Copy link
Copy Markdown
Member

Also please run hack/update-featuregate.sh

@Jefftree

Jefftree commented Sep 6, 2024

Copy link
Copy Markdown
Member

Please squash into one commit, otherwise LGTM. Thanks!

@Adarsh-verma-14

Adarsh-verma-14 commented Sep 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Author

Please squash into one commit, otherwise LGTM. Thanks!

sure, done!!

Jefftree
Jefftree reviewed Sep 6, 2024
View reviewed changes
Comment thread pkg/features/kube_features.go
@Jefftree

Jefftree commented Sep 6, 2024

Copy link
Copy Markdown
Member

Perfect thanks!
/lgtm
/assign @jpbetz

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2024
@k8s-ci-robot

k8s-ci-robot commented Sep 6, 2024

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 80ba28096f653ff69af167bccc76f79623ab2863

@Adarsh-verma-14 Adarsh-verma-14 deleted the remove-duplication branch September 9, 2024 13:07
@Adarsh-verma-14 Adarsh-verma-14 restored the remove-duplication branch September 9, 2024 13:09
@Adarsh-verma-14 Adarsh-verma-14 mentioned this pull request Sep 9, 2024
Closed
@Jefftree Jefftree mentioned this pull request Sep 10, 2024
Merged
jpbetz
jpbetz reviewed Sep 10, 2024
View reviewed changes

@jpbetz jpbetz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

I need to promote this in a follow up

@k8s-ci-robot

k8s-ci-robot commented Sep 10, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adarsh-verma-14, jpbetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0aea469 into kubernetes:master Sep 10, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Sep 10, 2024
@Jefftree Jefftree mentioned this pull request Sep 24, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dims dims Awaiting requested review from dims

@thockin thockin Awaiting requested review from thockin

2 more reviewers

@jpbetz jpbetz jpbetz left review comments

@Jefftree Jefftree Jefftree left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jpbetz jpbetz

@Jefftree Jefftree

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

v1.32

Development

Successfully merging this pull request may close these issues.

4 participants

@Adarsh-verma-14 @k8s-ci-robot @Jefftree @jpbetz