Skip to content

Revert "Automated cherry pick of #109124: Winkernel proxier cache HNS data to improve syncProxyRules"#110585

Merged
k8s-ci-robot merged 1 commit into
kubernetes:release-1.23from
marosset:revert-109981-automated-cherry-pick-of-#109124-upstream-release-1.23
Jun 15, 2022
Merged

Revert "Automated cherry pick of #109124: Winkernel proxier cache HNS data to improve syncProxyRules"#110585
k8s-ci-robot merged 1 commit into
kubernetes:release-1.23from
marosset:revert-109981-automated-cherry-pick-of-#109124-upstream-release-1.23

Conversation

@jsturtevant

@jsturtevant jsturtevant commented Jun 14, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reverts #109981 for 1.23 branch

We have noticed this is failing on our dockershim related tests: https://testgrid.k8s.io/sig-windows-1.23-release#aks-engine-windows-dockershim-1.23

the changeset when this started failing: df140a7...3943991

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-e2e-aks-engine-azure-1-23-windows/1535071534270386176

Release-note

NONE

/sig windows
/assign @marosset @daschott

@jsturtevant
Revert "Automated cherry pick of kubernetes#109124: Winkernel proxier…
99c3de2 
… cache HNS data to improve syncProxyRules"
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Jun 14, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jun 14, 2022
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/windows Categorizes an issue or PR as relevant to SIG Windows. labels Jun 14, 2022
@k8s-ci-robot

k8s-ci-robot commented Jun 14, 2022

Copy link
Copy Markdown
Contributor

@jsturtevant: GitHub didn't allow me to assign the following users: daschott.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

Reverts #109981 for 1.23 branch

We have noticed this is failing on our dockershim related tests: https://testgrid.k8s.io/sig-windows-1.23-release#aks-engine-windows-dockershim-1.23

the changeset when this started failing: df140a7...3943991

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-e2e-aks-engine-azure-1-23-windows/1535071534270386176

/sig windows
/assign @marosset @daschott

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 14, 2022
@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Jun 14, 2022
@jsturtevant

jsturtevant commented Jun 15, 2022

Copy link
Copy Markdown
Contributor Author

/test pull-kubernetes-e2e-aks-engine-windows-dockershim-1-23

@jsturtevant jsturtevant mentioned this pull request Jun 15, 2022
Merged
@daschott

daschott commented Jun 15, 2022

Copy link
Copy Markdown
Contributor

I have raised a proposed fix to this regression here: #110590

@jsturtevant

jsturtevant commented Jun 15, 2022

Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@jsturtevant

jsturtevant commented Jun 15, 2022

Copy link
Copy Markdown
Contributor Author

/retest

@jsturtevant jsturtevant mentioned this pull request Jun 15, 2022
Merged
@jsturtevant

jsturtevant commented Jun 15, 2022

Copy link
Copy Markdown
Contributor Author

dockershim can not run the failed tests kubernetes/test-infra#26586 fixes this
/test pull-kubernetes-e2e-aks-engine-windows-dockershim-1-23

@jsturtevant

jsturtevant commented Jun 15, 2022

Copy link
Copy Markdown
Contributor Author

/test pull-kubernetes-e2e-aks-engine-windows-containerd-1-23

@jsturtevant

jsturtevant commented Jun 15, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

an alternative to reverting is #110590

@liggitt

liggitt commented Jun 15, 2022

Copy link
Copy Markdown
Member

an alternative to reverting is #110590

it seems like we should revert to restore status quo for the impending release rather than review net new code under time pressure

@marosset

marosset commented Jun 15, 2022

Copy link
Copy Markdown
Contributor

/kind bug
/priority critical-urgent
/triage accepted

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 15, 2022
@k8s-ci-robot k8s-ci-robot removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 15, 2022
@marosset

marosset commented Jun 15, 2022

Copy link
Copy Markdown
Contributor

/lgtm
/approve
/assign @sbangari

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 15, 2022
@sbangari

sbangari commented Jun 15, 2022

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot

k8s-ci-robot commented Jun 15, 2022

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, marosset, sbangari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2022
@puerco

puerco commented Jun 15, 2022

Copy link
Copy Markdown
Member

Test timed out
/test pull-kubernetes-e2e-aks-engine-windows-dockershim-1-23

@jsturtevant

jsturtevant commented Jun 15, 2022

Copy link
Copy Markdown
Contributor Author

/test pull-kubernetes-e2e-aks-engine-windows-containerd-1-23

@puerco

puerco commented Jun 15, 2022

Copy link
Copy Markdown
Member

We ran those two last ones in parallel, one was successful but the other timed out again :\
/test pull-kubernetes-e2e-aks-engine-windows-containerd-1-23

@puerco

puerco commented Jun 15, 2022

Copy link
Copy Markdown
Member

/test pull-kubernetes-e2e-aks-engine-windows-dockershim-1-23

@puerco

puerco commented Jun 15, 2022

Copy link
Copy Markdown
Member

Thanks @jsturtevant !
/lgtm

@puerco puerco added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 15, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jun 15, 2022
@k8s-ci-robot k8s-ci-robot merged commit 82fedfd into kubernetes:release-1.23 Jun 15, 2022
@marosset marosset deleted the revert-109981-automated-cherry-pick-of-#109124-upstream-release-1.23 branch October 31, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dineshgovindasamy dineshgovindasamy Awaiting requested review from dineshgovindasamy

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@puerco puerco

@marosset marosset

@sbangari sbangari

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

v1.23

Development

Successfully merging this pull request may close these issues.

7 participants

@jsturtevant @k8s-ci-robot @daschott @liggitt @marosset @sbangari @puerco