Automated cherry pick of #109124: Winkernel proxier cache HNS data to improve syncProxyRules#109981
Conversation
Resolved issues with proxy rules taking a long time to be synced on Windows, by caching HNS data. In particular, the following HNS data will be cached for the context of syncProxyRules: * HNS endpoints * HNS load balancers
|
/kind bug |
|
/assign @daschott @jsturtevant |
|
@marosset: GitHub didn't allow me to assign the following users: daschott. Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-kubernetes-e2e-aks-engine-windows-containerd-1-23 |
| klog.V(3).InfoS("Skipped creating Hns LoadBalancer for loadBalancer Ingress resources", "lbIngressIP", lbIngressIP) | ||
| } | ||
|
|
||
| if proxier.forwardHealthCheckVip && gatewayHnsendpoint != nil { |
There was a problem hiding this comment.
To untangle this from the additions in 78a507b, we need to remove this nested condition.
There was a problem hiding this comment.
the health check feature fix landed in 1.24 which is why this needs to be removed here and didn't need to be removed in the backport to 1.24
|
/retest |
|
/test pull-kubernetes-e2e-aks-engine-windows-containerd-1-23 /lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cc @kubernetes/release-managers |
|
May I know when will this be merged? I am experiencing a similar issue and would like to verify if this fix will help. |
|
Thank you @marosset !! |
Cherry pick of #109124 on release-1.23.
#109124: Winkernel proxier cache HNS data to improve syncProxyRules
For details on the cherry pick process, see the cherry pick requests page.