Skip to content

Revert "Automated cherry pick of #109124: Winkernel proxier cache HNS data to improve syncProxyRules"#110584

Merged
k8s-ci-robot merged 1 commit into
kubernetes:release-1.22from
marosset:revert-109985-automated-cherry-pick-of-#109124-upstream-release-1.22
Jun 15, 2022
Merged

Revert "Automated cherry pick of #109124: Winkernel proxier cache HNS data to improve syncProxyRules"#110584
k8s-ci-robot merged 1 commit into
kubernetes:release-1.22from
marosset:revert-109985-automated-cherry-pick-of-#109124-upstream-release-1.22

Conversation

@jsturtevant

@jsturtevant jsturtevant commented Jun 14, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reverts #109985 for 1.22 branch

We have noticed this is failing on our dockershim related tests: https://testgrid.k8s.io/sig-windows-1.22-release#aks-engine-windows-dockershim-1.22

the changeset when this started failing: af521aa...6de0e5a

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-e2e-aks-engine-azure-1-22-windows/1536521484288135168

Release-note

NONE

/sig windows
/assign @marosset @daschott

@jsturtevant
Revert "Automated cherry pick of kubernetes#109124: Winkernel proxier…
f2021a6 
… cache HNS data to improve syncProxyRules"
@k8s-ci-robot

k8s-ci-robot commented Jun 14, 2022

Copy link
Copy Markdown
Contributor

@jsturtevant: GitHub didn't allow me to assign the following users: daschott.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

Reverts #109985 for 1.22 branch

We have noticed this is failing on our dockershim related tests: https://testgrid.k8s.io/sig-windows-1.22-release#aks-engine-windows-dockershim-1.22

the changeset when this started failing: af521aa...6de0e5a

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-e2e-aks-engine-azure-1-22-windows/1536521484288135168

/sig windows
/assign @marosset @daschott

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 14, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 14, 2022
@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Jun 14, 2022
@jsturtevant

jsturtevant commented Jun 15, 2022

Copy link
Copy Markdown
Contributor Author

/test pull-kubernetes-e2e-aks-engine-windows-dockershim-1-22

@k8s-ci-robot

k8s-ci-robot commented Jun 15, 2022

Copy link
Copy Markdown
Contributor

@jsturtevant: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-kubernetes-conformance-kind-ga-only-parallel
  • /test pull-kubernetes-coverage-unit
  • /test pull-kubernetes-dependencies
  • /test pull-kubernetes-e2e-gce
  • /test pull-kubernetes-e2e-gce-100-performance
  • /test pull-kubernetes-e2e-gce-canary
  • /test pull-kubernetes-e2e-gce-network-proxy-http-connect
  • /test pull-kubernetes-e2e-gce-no-stage
  • /test pull-kubernetes-e2e-gce-ubuntu
  • /test pull-kubernetes-e2e-gce-ubuntu-containerd
  • /test pull-kubernetes-e2e-gce-ubuntu-containerd-canary
  • /test pull-kubernetes-e2e-kind
  • /test pull-kubernetes-e2e-kind-ipv6
  • /test pull-kubernetes-files-remake
  • /test pull-kubernetes-integration
  • /test pull-kubernetes-node-e2e-containerd
  • /test pull-kubernetes-typecheck
  • /test pull-kubernetes-unit
  • /test pull-kubernetes-verify
  • /test pull-kubernetes-verify-govet-levee

The following commands are available to trigger optional jobs:

  • /test check-dependency-stats
  • /test pull-kubernetes-conformance-kind-ipv6-parallel
  • /test pull-kubernetes-cross
  • /test pull-kubernetes-e2e-aks-engine-azure-disk-windows-dockershim-1-22
  • /test pull-kubernetes-e2e-aks-engine-azure-file-windows-dockershim-1-22
  • /test pull-kubernetes-e2e-aks-engine-windows-containerd-1-22
  • /test pull-kubernetes-e2e-aks-engine-windows-dockershim-1-22
  • /test pull-kubernetes-e2e-capz-azure-disk
  • /test pull-kubernetes-e2e-capz-azure-disk-vmss
  • /test pull-kubernetes-e2e-capz-azure-file
  • /test pull-kubernetes-e2e-capz-azure-file-vmss
  • /test pull-kubernetes-e2e-capz-conformance
  • /test pull-kubernetes-e2e-capz-ha-control-plane
  • /test pull-kubernetes-e2e-containerd-gce
  • /test pull-kubernetes-e2e-gce-correctness
  • /test pull-kubernetes-e2e-gce-device-plugin-gpu
  • /test pull-kubernetes-e2e-gce-network-proxy-grpc
  • /test pull-kubernetes-e2e-gci-gce-autoscaling
  • /test pull-kubernetes-e2e-kind-dual-canary
  • /test pull-kubernetes-e2e-kind-ipvs-dual-canary
  • /test pull-kubernetes-e2e-kind-multizone
  • /test pull-kubernetes-e2e-kops-aws
  • /test pull-kubernetes-kubemark-e2e-gce-big
  • /test pull-kubernetes-node-e2e-podutil
  • /test pull-kubernetes-node-kubelet-serial-122
  • /test pull-publishing-bot-validate

Use /test all to run the following jobs that were automatically triggered:

  • pull-kubernetes-conformance-kind-ga-only-parallel
  • pull-kubernetes-dependencies
  • pull-kubernetes-e2e-gce-100-performance
  • pull-kubernetes-e2e-gce-ubuntu-containerd
  • pull-kubernetes-e2e-kind
  • pull-kubernetes-e2e-kind-ipv6
  • pull-kubernetes-integration
  • pull-kubernetes-node-e2e-containerd
  • pull-kubernetes-typecheck
  • pull-kubernetes-unit
  • pull-kubernetes-verify
  • pull-kubernetes-verify-govet-levee
Details

In response to this:

/test pull-kubernetes-e2e-aks-engine-windows-dockershim-1-23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsturtevant jsturtevant mentioned this pull request Jun 15, 2022
Merged
@daschott

daschott commented Jun 15, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

I have raised a proposed fix to this regression here: #110592

@jsturtevant

jsturtevant commented Jun 15, 2022

Copy link
Copy Markdown
Contributor Author

/retest

@marosset

marosset commented Jun 15, 2022

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2022
@marosset

marosset commented Jun 15, 2022

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@jsturtevant

jsturtevant commented Jun 15, 2022

Copy link
Copy Markdown
Contributor Author

removing the PR fixed the kubeproxy issues. looks like there was a flake on one of the tests

/retest

@jsturtevant

jsturtevant commented Jun 15, 2022

Copy link
Copy Markdown
Contributor Author

/test pull-kubernetes-e2e-aks-engine-windows-containerd-1-22

@jsturtevant

jsturtevant commented Jun 15, 2022

Copy link
Copy Markdown
Contributor Author

An alternative to reverting is #110592

@liggitt

liggitt commented Jun 15, 2022

Copy link
Copy Markdown
Member

An alternative to reverting is #110592

it seems like we should revert to restore status quo for the impending release rather than review net new code under time pressure

@marosset

marosset commented Jun 15, 2022

Copy link
Copy Markdown
Contributor

/kind bug
/triage accepted
/priority important-urgent

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 15, 2022
@k8s-ci-robot

k8s-ci-robot commented Jun 15, 2022

Copy link
Copy Markdown
Contributor

@marosset: The label(s) priority/important-urgent cannot be applied, because the repository doesn't have them.

Details

In response to this:

/kind bug
/triage accepted
/priority important-urgent

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 15, 2022
@marosset

marosset commented Jun 15, 2022

Copy link
Copy Markdown
Contributor

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 15, 2022
@marosset

marosset commented Jun 15, 2022

Copy link
Copy Markdown
Contributor

/lgtm
/approve
/assign @sbangari

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 15, 2022
@sbangari

sbangari commented Jun 15, 2022

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot

k8s-ci-robot commented Jun 15, 2022

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, marosset, sbangari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2022
@jsturtevant

jsturtevant commented Jun 15, 2022

Copy link
Copy Markdown
Contributor Author

that run hit the Windows HNS locking bug #98574
/test pull-kubernetes-e2e-aks-engine-windows-dockershim-1-22

@puerco

puerco commented Jun 15, 2022

Copy link
Copy Markdown
Member

Thanks @jsturtevant !
/lgtm

@puerco puerco added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 15, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jun 15, 2022
@k8s-ci-robot k8s-ci-robot merged commit cc98836 into kubernetes:release-1.22 Jun 15, 2022
@marosset marosset deleted the revert-109985-automated-cherry-pick-of-#109124-upstream-release-1.22 branch October 31, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@madhanrm madhanrm Awaiting requested review from madhanrm

@sbangari sbangari Awaiting requested review from sbangari

Assignees

@puerco puerco

@marosset marosset

@sbangari sbangari

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

v1.22

Development

Successfully merging this pull request may close these issues.

7 participants

@jsturtevant @k8s-ci-robot @daschott @marosset @liggitt @sbangari @puerco