Skip to content

Automated cherry pick of #109124: Winkernel proxier cache HNS data to improve syncProxyRules#109985

Merged
k8s-ci-robot merged 2 commits into
kubernetes:release-1.22from
marosset:automated-cherry-pick-of-#109124-upstream-release-1.22
Jun 9, 2022
Merged

Automated cherry pick of #109124: Winkernel proxier cache HNS data to improve syncProxyRules#109985
k8s-ci-robot merged 2 commits into
kubernetes:release-1.22from
marosset:automated-cherry-pick-of-#109124-upstream-release-1.22

Conversation

@marosset

@marosset marosset commented May 11, 2022

Copy link
Copy Markdown
Contributor

Cherry pick of #109124 on release-1.22.

#109124: Winkernel proxier cache HNS data to improve syncProxyRules

For details on the cherry pick process, see the cherry pick requests page.

@daschott @marosset
Winkernel proxier cache HNS data to improve syncProxyRules performance
eee55a0 
Resolved issues with proxy rules taking a long time to be synced on Windows, by caching HNS data.

In particular, the following HNS data will be cached for the context of syncProxyRules:
  * HNS endpoints

  * HNS load balancers
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 11, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 11, 2022
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 11, 2022
@marosset

marosset commented May 11, 2022

Copy link
Copy Markdown
Contributor Author

/kind bug
/triage accepted
/priority important-soon
/sig windows

/assign @daschott @jsturtevant

/test pull-kubernetes-e2e-aks-engine-windows-containerd-1-22

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 11, 2022
@k8s-ci-robot

k8s-ci-robot commented May 11, 2022

Copy link
Copy Markdown
Contributor

@marosset: GitHub didn't allow me to assign the following users: daschott.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/kind bug
/triage accepted
/priority important-soon
/sig windows

/assign @daschott @jsturtevant

/test pull-kubernetes-e2e-aks-engine-windows-containerd-1-22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/windows Categorizes an issue or PR as relevant to SIG Windows. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 11, 2022
@jsturtevant

jsturtevant commented May 12, 2022

Copy link
Copy Markdown
Contributor

https://github.com/kubernetes/kubernetes/pull/109985/commits removes the section related to a fix that came in 1.24: #109981 (comment)

@marosset looks like the verify is a valid error on the boilerplate header

@cpanato cpanato mentioned this pull request May 20, 2022
Merged
@marosset marosset force-pushed the automated-cherry-pick-of-#109124-upstream-release-1.22 branch from 93f0b09 to 7fb440b Compare May 20, 2022 20:59
@marosset

marosset commented May 20, 2022

Copy link
Copy Markdown
Contributor Author

/test pull-kubernetes-e2e-aks-engine-windows-containerd-1-22

https://github.com/kubernetes/kubernetes/pull/109985/commits removes the section related to a fix that came in 1.24: #109981 (comment)

@marosset looks like the verify is a valid error on the boilerplate header

updated.
I'm pretty sure it was complaning about golang 1.17+ build directives (//go:build windows)

@marosset

marosset commented May 20, 2022

Copy link
Copy Markdown
Contributor Author

/assign @sbangari @khenidak @feiskyer
For windows kube-proxy PR review

@feiskyer

feiskyer commented May 23, 2022

Copy link
Copy Markdown
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2022
@k8s-ci-robot

k8s-ci-robot commented May 23, 2022

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2022
@marosset

marosset commented May 23, 2022

Copy link
Copy Markdown
Contributor Author

/cc @kubernetes/release-managers
This is ready for final review

@k8s-ci-robot k8s-ci-robot requested a review from a team May 23, 2022 20:13
@puerco

puerco commented Jun 9, 2022

Copy link
Copy Markdown
Member

Thank you @marosset !!
/lgtm

@puerco puerco added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 9, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jun 9, 2022
@Verolop

Verolop commented Jun 9, 2022

Copy link
Copy Markdown

/retest-required

@k8s-ci-robot k8s-ci-robot merged commit 290238f into kubernetes:release-1.22 Jun 9, 2022
@jsturtevant jsturtevant mentioned this pull request Jun 14, 2022
Merged
@daschott daschott mentioned this pull request Jun 15, 2022
Closed
@marosset marosset deleted the automated-cherry-pick-of-#109124-upstream-release-1.22 branch October 31, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elweb9858 elweb9858 Awaiting requested review from elweb9858

@ksubrmnn ksubrmnn Awaiting requested review from ksubrmnn

Assignees

@jsturtevant jsturtevant

@feiskyer feiskyer

@puerco puerco

@khenidak khenidak

@sbangari sbangari

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

v1.22

Development

Successfully merging this pull request may close these issues.

9 participants

@marosset @k8s-ci-robot @jsturtevant @feiskyer @puerco @Verolop @khenidak @sbangari @daschott