Skip to content

Automated cherry pick of #109124: Winkernel proxier cache HNS data to improve syncProxyRules#109974

Merged
k8s-ci-robot merged 1 commit into
kubernetes:release-1.24from
marosset:automated-cherry-pick-of-#109124-upstream-release-1.24
Jun 9, 2022
Merged

Automated cherry pick of #109124: Winkernel proxier cache HNS data to improve syncProxyRules#109974
k8s-ci-robot merged 1 commit into
kubernetes:release-1.24from
marosset:automated-cherry-pick-of-#109124-upstream-release-1.24

Conversation

@marosset

@marosset marosset commented May 11, 2022

Copy link
Copy Markdown
Contributor

Cherry pick of #109124 on release-1.24.

#109124: Winkernel proxier cache HNS data to improve syncProxyRules

For details on the cherry pick process, see the cherry pick requests page.

@daschott @marosset
Winkernel proxier cache HNS data to improve syncProxyRules performance
68e5e40 
Resolved issues with proxy rules taking a long time to be synced on Windows, by caching HNS data.

In particular, the following HNS data will be cached for the context of syncProxyRules:
  * HNS endpoints

  * HNS load balancers
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone May 11, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 11, 2022
@k8s-ci-robot k8s-ci-robot requested review from feiskyer and sbangari May 11, 2022 16:25
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 11, 2022
@jsturtevant

jsturtevant commented May 11, 2022

Copy link
Copy Markdown
Contributor

/triage accepted
/priority important-soon
/kind bug

@jsturtevant

jsturtevant commented May 11, 2022

Copy link
Copy Markdown
Contributor

/sig windows

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/bug Categorizes issue or PR as related to a bug. sig/windows Categorizes an issue or PR as relevant to SIG Windows. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 11, 2022
@marosset

marosset commented May 11, 2022

Copy link
Copy Markdown
Contributor Author

/assign @daschott @jsturtevant

@k8s-ci-robot

k8s-ci-robot commented May 11, 2022

Copy link
Copy Markdown
Contributor

@marosset: GitHub didn't allow me to assign the following users: daschott.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @daschott @jsturtevant

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marosset

marosset commented May 11, 2022

Copy link
Copy Markdown
Contributor Author

/test pull-kubernetes-e2e-aks-engine-windows-containerd-1-23

@k8s-ci-robot

k8s-ci-robot commented May 11, 2022

Copy link
Copy Markdown
Contributor

@marosset: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-kubernetes-conformance-kind-ga-only-parallel
  • /test pull-kubernetes-coverage-unit
  • /test pull-kubernetes-dependencies
  • /test pull-kubernetes-e2e-gce
  • /test pull-kubernetes-e2e-gce-100-performance
  • /test pull-kubernetes-e2e-gce-canary
  • /test pull-kubernetes-e2e-gce-network-proxy-http-connect
  • /test pull-kubernetes-e2e-gce-no-stage
  • /test pull-kubernetes-e2e-gce-ubuntu-containerd
  • /test pull-kubernetes-e2e-gce-ubuntu-containerd-canary
  • /test pull-kubernetes-e2e-kind
  • /test pull-kubernetes-e2e-kind-ipv6
  • /test pull-kubernetes-files-remake
  • /test pull-kubernetes-integration
  • /test pull-kubernetes-kubemark-e2e-gce-scale
  • /test pull-kubernetes-node-e2e-containerd
  • /test pull-kubernetes-typecheck
  • /test pull-kubernetes-unit
  • /test pull-kubernetes-update
  • /test pull-kubernetes-verify
  • /test pull-kubernetes-verify-govet-levee

The following commands are available to trigger optional jobs:

  • /test check-dependency-stats
  • /test pull-kubernetes-conformance-kind-ipv6-parallel
  • /test pull-kubernetes-cross
  • /test pull-kubernetes-e2e-containerd-gce
  • /test pull-kubernetes-e2e-gce-correctness
  • /test pull-kubernetes-e2e-gce-device-plugin-gpu
  • /test pull-kubernetes-e2e-gce-network-proxy-grpc
  • /test pull-kubernetes-e2e-gci-gce-autoscaling
  • /test pull-kubernetes-e2e-kind-dual-canary
  • /test pull-kubernetes-e2e-kind-ipvs-dual-canary
  • /test pull-kubernetes-e2e-kind-multizone
  • /test pull-kubernetes-e2e-kops-aws
  • /test pull-kubernetes-kubemark-e2e-gce-big
  • /test pull-kubernetes-node-e2e-containerd-kubetest2
  • /test pull-publishing-bot-validate

Use /test all to run the following jobs that were automatically triggered:

  • pull-kubernetes-conformance-kind-ga-only-parallel
  • pull-kubernetes-dependencies
  • pull-kubernetes-e2e-gce-100-performance
  • pull-kubernetes-e2e-gce-ubuntu-containerd
  • pull-kubernetes-e2e-kind
  • pull-kubernetes-e2e-kind-ipv6
  • pull-kubernetes-integration
  • pull-kubernetes-node-e2e-containerd
  • pull-kubernetes-typecheck
  • pull-kubernetes-unit
  • pull-kubernetes-verify
  • pull-kubernetes-verify-govet-levee
Details

In response to this:

/test pull-kubernetes-e2e-aks-engine-windows-containerd-1-23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsturtevant

jsturtevant commented May 12, 2022

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2022
@jsturtevant

jsturtevant commented May 12, 2022

Copy link
Copy Markdown
Contributor

/test pull-kubernetes-e2e-aks-engine-windows-containerd-1-24
/test pull-kubernetes-e2e-capz-windows-containerd-1-24

@marosset

marosset commented May 18, 2022

Copy link
Copy Markdown
Contributor Author

/assign @sbangari

@marosset

marosset commented May 18, 2022

Copy link
Copy Markdown
Contributor Author

/assign @feiskyer

@khenidak

khenidak commented May 18, 2022

Copy link
Copy Markdown
Contributor

/retest
/lgtm
/approve

Thanks for this.

@k8s-ci-robot

k8s-ci-robot commented May 18, 2022

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khenidak, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2022
@marosset

marosset commented May 19, 2022

Copy link
Copy Markdown
Contributor Author

@kubernetes/release-managers
This should be ready for backporting to 1.24
Thanks

@cpanato

cpanato commented May 20, 2022

Copy link
Copy Markdown
Member

need wait the approvals for #109985 and #109981

@marosset

marosset commented May 23, 2022

Copy link
Copy Markdown
Contributor Author

need wait the approvals for #109985 and #109981

These cherry-pick PRs are now approved

@puerco

puerco commented Jun 9, 2022

Copy link
Copy Markdown
Member

Thank you @marosset !!
/lgtm

@puerco puerco added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 9, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jun 9, 2022
@k8s-triage-robot

k8s-triage-robot commented Jun 9, 2022

Copy link
Copy Markdown

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit 7f588da into kubernetes:release-1.24 Jun 9, 2022
@marosset marosset deleted the automated-cherry-pick-of-#109124-upstream-release-1.24 branch October 31, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@sbangari sbangari Awaiting requested review from sbangari

Assignees

@jsturtevant jsturtevant

@feiskyer feiskyer

@puerco puerco

@khenidak khenidak

@sbangari sbangari

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

v1.24

Development

Successfully merging this pull request may close these issues.

10 participants

@marosset @jsturtevant @k8s-ci-robot @khenidak @cpanato @puerco @k8s-triage-robot @feiskyer @sbangari @daschott