Fix node bootstrap challenge response hashing#18043
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Mar 9, 2026
Merged
Fix node bootstrap challenge response hashing#18043k8s-ci-robot merged 1 commit intokubernetes:masterfrom
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
The previous `hasher.Sum(nonce)` doesn't feed data into the hasher so the resulting `hasher.Sum(nil)` was always identical. This replaces those `hasher.Sum()` calls with `hasher.Write()`
hakman
approved these changes
Mar 9, 2026
Member
hakman
left a comment
There was a problem hiding this comment.
Nice catch, should we cherry-pick down to 1.32?
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Mar 9, 2026
Member
Author
done ✅ |
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 9, 2026
…43-origin-release-1.32 Automated cherry pick of #18043: Fix node bootstrap challenge response hashing
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 9, 2026
…43-origin-release-1.34 Automated cherry pick of #18043: Fix node bootstrap challenge response hashing
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 9, 2026
…43-origin-release-1.33 Automated cherry pick of #18043: Fix node bootstrap challenge response hashing
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 9, 2026
…43-origin-release-1.35 Automated cherry pick of #18043: Fix node bootstrap challenge response hashing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous
hasher.Sum(nonce)doesn't feed data into the hasher so the resultinghasher.Sum(nil)was always identical. This replaces thosehasher.Sum()calls withhasher.Write().