Skip to content

Automated cherry pick of #18043: Fix node bootstrap challenge response hashing#18045

Merged
k8s-ci-robot merged 1 commit intokubernetes:release-1.34from
rifelpet:automated-cherry-pick-of-#18043-origin-release-1.34
Mar 9, 2026
Merged

Automated cherry pick of #18043: Fix node bootstrap challenge response hashing#18045
k8s-ci-robot merged 1 commit intokubernetes:release-1.34from
rifelpet:automated-cherry-pick-of-#18043-origin-release-1.34

Conversation

@rifelpet
Copy link
Copy Markdown
Member

@rifelpet rifelpet commented Mar 9, 2026

Cherry pick of #18043 on release-1.34.

#18043: Fix node bootstrap challenge response hashing

For details on the cherry pick process, see the cherry pick requests page.


The previous `hasher.Sum(nonce)` doesn't feed data into the hasher so the resulting `hasher.Sum(nil)` was always identical.
This replaces those `hasher.Sum()` calls with `hasher.Write()`
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Mar 9, 2026
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 9, 2026
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 9, 2026
@hakman
Copy link
Copy Markdown
Member

hakman commented Mar 9, 2026

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2026
@k8s-ci-robot k8s-ci-robot merged commit 97d7f19 into kubernetes:release-1.34 Mar 9, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants