[KEP 3960]: Promote PodLifecycleSleepAction to stable #4866
Conversation
|
Aslo /cc @SergeyKanzhelev |
wojtek-t
left a comment
There was a problem hiding this comment.
Two minor nits - other than that LGTM.
|
I'm approving the PRR, but adding a hold to have the two nits addressed. /approve PRR |
|
/lgtm |
| - [x] (R) Ensure GA e2e tests meet requirements for [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md) | ||
| - [x] (R) Minimum Two Week Window for GA e2e tests to prove flake free | ||
| - [x] (R) Graduation criteria is in place | ||
| - [ ] (R) [all GA Endpoints](https://github.com/kubernetes/community/pull/1806) must be hit by [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md) |
There was a problem hiding this comment.
Can you please add this as a graduation criteria for stable. Which tests will be marked as Conformance?
There was a problem hiding this comment.
Added a link pointed to the e2e test.
Also, should we unmark this line first and then remark it once the e2e tests are promoted to conformance?
| @@ -47,10 +47,10 @@ Items marked with (R) are required *prior to targeting to a milestone / release* | |||
| - [x] (R) Design details are appropriately documented | |||
| - [x] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors) | |||
| - [x] e2e Tests for all Beta API Operations (endpoints) | |||
There was a problem hiding this comment.
tests mentioned later in the doc are still pointing to the alpha job: https://testgrid.k8s.io/presubmits-kubernetes-nonblocking#pull-kubernetes-e2e-gce-cos-alpha-features Why alpha? Is there a better link?
There was a problem hiding this comment.
So although the job name contains alpha, it actually runs many non-alpha feature test.
We mentioned this test in the doc because we added this specific fg to the test config(kubernetes/test-infra#31959), so that the test for this feature can be run periodically. It doesn't care if the feature is in alpha stage or beta stage.
We can change the link, but this should be done after this fature is GAed, and the tests are run periodically in another job?
For now, I think this is the only job which periodically run the test for this feature.
|
/assign @SergeyKanzhelev This still needs a sig approval. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AxeZhan, SergeyKanzhelev, thockin, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PodLifecycleSleepAction is planned to graduate to ga in 1.32.