Skip to content

Run PodLifecycleSleepAction in pull-kubernetes-e2e-gce-cos-alpha-features#31959

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
AxeZhan:beta3960
Feb 19, 2024
Merged

Run PodLifecycleSleepAction in pull-kubernetes-e2e-gce-cos-alpha-features#31959
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
AxeZhan:beta3960

Conversation

@AxeZhan

@AxeZhan AxeZhan commented Feb 12, 2024

Copy link
Copy Markdown
Member

I'd like to have tests for feature PodLifecycleSleepAction always run in job pull-kubernetes-e2e-gce-cos-alpha-features like some other features.

We're graduating this feature to beta in v1.30, and we'd like to have some jobs always running these tests to show us potential problems.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 12, 2024
@AxeZhan AxeZhan mentioned this pull request Feb 12, 2024
Merged
kannon92
kannon92 reviewed Feb 12, 2024
View reviewed changes

@kannon92 kannon92 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm from sig-node side.

@kannon92

kannon92 commented Feb 12, 2024

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2024
@kannon92

kannon92 commented Feb 12, 2024

Copy link
Copy Markdown
Contributor

/assign @aojea
or you could point to someone who manages that job.

@kannon92

kannon92 commented Feb 15, 2024

Copy link
Copy Markdown
Contributor

/assign @cheftako @andrewsykim

@dims

dims commented Feb 19, 2024

Copy link
Copy Markdown
Member

/approve
/lgtm

@k8s-ci-robot

k8s-ci-robot commented Feb 19, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AxeZhan, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit 332c5a4 into kubernetes:master Feb 19, 2024
@k8s-ci-robot

k8s-ci-robot commented Feb 19, 2024

Copy link
Copy Markdown
Contributor

@AxeZhan: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key gcp-gce.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml
Details

In response to this:

I'd like to have tests for feature PodLifecycleSleepAction always run in job pull-kubernetes-e2e-gce-cos-alpha-features like some other features.

We're graduating this feature to beta in v1.30, and we'd like to have some jobs always running these tests to show us potential problems.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AxeZhan AxeZhan mentioned this pull request Sep 24, 2024
Merged
@sreeram-venkitesh sreeram-venkitesh mentioned this pull request Mar 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@cheftako cheftako Awaiting requested review from cheftako

1 more reviewer

@kannon92 kannon92 kannon92 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dims dims

@cheftako cheftako

@kannon92 kannon92

@aojea aojea

@andrewsykim andrewsykim

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@AxeZhan @kannon92 @dims @k8s-ci-robot @cheftako @aojea @andrewsykim