Skip to content

[occm] add load-balancer-address annotation doc#2110

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
zetaab:docnewannotation
Feb 19, 2023
Merged

[occm] add load-balancer-address annotation doc#2110
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
zetaab:docnewannotation

Conversation

@zetaab
Copy link
Copy Markdown
Member

@zetaab zetaab commented Feb 18, 2023

What this PR does / why we need it:

feature were added #2097 but we are missing docs
Which issue this PR fixes(if applicable):
fixes #

Special notes for reviewers:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 18, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 18, 2023
@jichenjc
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit debd751 into kubernetes:master Feb 19, 2023
@zetaab zetaab deleted the docnewannotation branch February 19, 2023 19:39
m-bull pushed a commit to stackhpc/cloud-provider-openstack that referenced this pull request Feb 23, 2023
m-bull pushed a commit to stackhpc/cloud-provider-openstack that referenced this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants