[occm] add annotation for real loadbalancer address#2097
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Feb 18, 2023
Merged
[occm] add annotation for real loadbalancer address#2097k8s-ci-robot merged 1 commit intokubernetes:masterfrom
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
This was referenced Feb 15, 2023
1f52461 to
11c881d
Compare
Member
Author
|
/test openstack-cloud-controller-manager-e2e-test |
3 similar comments
Member
Author
|
/test openstack-cloud-controller-manager-e2e-test |
Member
Author
|
/test openstack-cloud-controller-manager-e2e-test |
Member
Author
|
/test openstack-cloud-controller-manager-e2e-test |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jichenjc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
please open a follow up PR to doc the new annotation.. |
This was referenced Feb 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We need somekind of way to see the real ip address especially when using hostname annotation
Which issue this PR fixes(if applicable):
fixes #2095
Special notes for reviewers:
Release note: