Docker updates to CMake 3.16#80
Merged
Merged
Conversation
Frenzie
commented
Jun 2, 2022
| @@ -1,4 +1,4 @@ | |||
| FROM koreader/kobase-python:0.2.2 | |||
| FROM koreader/kobase-18.04:0.3.0 | |||
Member
Author
There was a problem hiding this comment.
Android isn't participating yet for some reason. ;_;
The rest is good.
Frenzie
added a commit
to koreader/koreader-base
that referenced
this pull request
Jun 3, 2022
Frenzie
added a commit
to koreader/koreader-base
that referenced
this pull request
Apr 2, 2023
Frenzie
commented
Apr 2, 2023
| && update-alternatives --install /usr/bin/clang++ clang++ /usr/bin/clang++-12 380 \ | ||
| && update-alternatives --install /usr/bin/clang-cpp clang-cpp /usr/bin/clang-cpp-12 380 \ | ||
| && update-alternatives --install /usr/bin/gcc gcc /usr/bin/clang-12 380 \ | ||
| && apt-get install -y --no-install-recommends libtool-bin clang-16 \ |
Member
Author
There was a problem hiding this comment.
Not really sure why only clang but either way, also see https://github.com/zeromq/libzmq/issues/1385
In principle it should already be there so this is rather strange:
virdevenv/docker/ubuntu/baseimage-18.04/bootstrap.sh
Lines 17 to 20 in d4d0eda
Frenzie
added a commit
to koreader/koreader-base
that referenced
this pull request
Apr 2, 2023
See koreader/virdevenv#80 For #1486 Also includes an update to Clang 16.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using 18.04 for all the cross stuff, cf. #79.
This change is