Skip to content

[CI] Update all but Android to new CMake 3.16 image#1487

Merged
Frenzie merged 4 commits into
masterfrom
Frenzie-patch-1
Apr 2, 2023
Merged

[CI] Update all but Android to new CMake 3.16 image#1487
Frenzie merged 4 commits into
masterfrom
Frenzie-patch-1

Conversation

@Frenzie

@Frenzie Frenzie commented Jun 3, 2022

Copy link
Copy Markdown
Member

See koreader/virdevenv#80

For #1486

Android is for next week.


This change is Reviewable

@Frenzie

Frenzie commented Jun 3, 2022

Copy link
Copy Markdown
Member Author

Grr.

Luacheck results
/home/ko/local/bin/luajit
Checking ffi/SDL2_0.lua                           1 warning

    ffi/SDL2_0.lua:221:8: 'not (x > y)' can be replaced by 'x <= y' (if neither side is a table or NaN)

Checking ffi/mupdf.lua                            1 warning

    ffi/mupdf.lua:111:8: 'not (x > y)' can be replaced by 'x <= y' (if neither side is a table or NaN)

Checking ffi/rtc.lua                              2 warnings

    ffi/rtc.lua:259:8: 'not (x == y)' can be replaced by 'x ~= y' (if neither side is a table or NaN)
    ffi/rtc.lua:263:23: 'not (x == y)' can be replaced by 'x ~= y' (if neither side is a table or NaN)

Total: 4 warnings / 0 errors in 90 files

Exited with code exit status 1

@NiLuJe

NiLuJe commented Jun 3, 2022

Copy link
Copy Markdown
Member

That's from luacheck 0.26.1?

(I'm still on 0.25.0 locally, I'll look into it on Monday if nobody beats me to it).

@Frenzie

Frenzie commented Jun 4, 2022 via email

Copy link
Copy Markdown
Member Author

NiLuJe added a commit to NiLuJe/koreader-base that referenced this pull request Jun 6, 2022
NiLuJe added a commit to NiLuJe/koreader that referenced this pull request Jun 6, 2022
Frenzie pushed a commit that referenced this pull request Jun 8, 2022
NiLuJe added a commit to NiLuJe/koreader that referenced this pull request Jun 11, 2022
NiLuJe added a commit to koreader/koreader that referenced this pull request Jun 11, 2022
rjd22 pushed a commit to koreader/koreader that referenced this pull request Nov 7, 2022
@Frenzie Frenzie merged commit 49504f6 into master Apr 2, 2023
@Frenzie Frenzie deleted the Frenzie-patch-1 branch April 2, 2023 16:32
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants