blitbuffer: RGB32 support for rounded corners#2233
Merged
Conversation
Member
|
I'd obviously prefer that with the C implementation in, too ;). (At a quick glance, it wouldn't look too gnarly to implement, just a bunch of code duplication). |
Member
Author
|
Looks like it's already there but the color parsing should be fixed: Lines 3151 to 3152 in b677605 Out of my abilities unfortunately. |
Member
|
Yeah, it already supports every target BB, which is why I mentioned it should be fairly easy (basically the same idea as fill_rect vs. fill_rect_RGB32) ;). I miiiiight have some time during winter break, but who knows really ;p. |
Member
Author
|
Lua version works fine on Kindle, frontend PR is ready. |
NiLuJe
approved these changes
Dec 8, 2025
Frenzie
approved these changes
Jan 19, 2026
Member
|
(Just so I don't forget to look into the missing C bits whenever free time becomes something that exists again xD) |
benoit-pierre
pushed a commit
to benoit-pierre/koreader
that referenced
this pull request
Jan 20, 2026
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
Jan 28, 2026
Fixes #11033. Depends on additional change in the available C-bindings from koreader/koreader-base#2260 Also includes koreader/koreader-base#2233
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
Fixes koreader#11033. Depends on additional change in the available C-bindings from koreader/koreader-base#2260 Also includes koreader/koreader-base#2233
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be used in colored buttons.
This change is