[PB700] Fix auto-orientation inversion after suspension#14895
Merged
Conversation
This fixes koreader#11033. As a prerequisite this needs an additional change in the available C-bindings from koreader/koreader-base#2260
This uses the changes from koreader/koreader-base#2260
Frenzie
reviewed
Jan 28, 2026
Frenzie
left a comment
Member
There was a problem hiding this comment.
lgtm, not sticking an approve on it because base will have to be updated before final merge.
Contributor
Author
|
@Frenzie thank you for the prompt review! |
Member
|
Your test is good enough for me. :-) |
jannickfahlbusch
added a commit
to jannickfahlbusch/koreader
that referenced
this pull request
Jan 29, 2026
koreader#14895 is a bit inefficient and does not take the option to lock the orientation in place. This change reuses the existing functionality and in turn respects the other settings as well
Frenzie
pushed a commit
that referenced
this pull request
Jan 29, 2026
#14895 is a bit inefficient and does not take the option to lock the orientation in place. This change reuses the existing functionality and in turn respects the other settings as well
3 tasks
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
Fixes koreader#11033. Depends on additional change in the available C-bindings from koreader/koreader-base#2260 Also includes koreader/koreader-base#2233
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
koreader#14895 is a bit inefficient and does not take the option to lock the orientation in place. This change reuses the existing functionality and in turn respects the other settings as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #11033.
As a prerequisite this needs an additional change in the available C-bindings from koreader/koreader-base#2260
This change is