tests: improve test runner and testsuite isolation#2016
Merged
Frenzie merged 1 commit intoJan 9, 2025
Conversation
- initial LUA paths are now setup by the runner itself, so it can be executed directly without needing to manually set them before - patch the LUA paths before actually executing the tests to remove the testsuite specific entries (e.g. `spec/rocks/…`), ensuring tests only have access to shipped packages
Member
Author
|
With this PR the testsuite would fail with the initial version of #2015 (prevent importing a test-only package: |
benoit-pierre
added a commit
to benoit-pierre/koreader
that referenced
this pull request
Jan 25, 2025
benoit-pierre
added a commit
to benoit-pierre/koreader
that referenced
this pull request
Jan 25, 2025
benoit-pierre
added a commit
to benoit-pierre/koreader
that referenced
this pull request
Jan 25, 2025
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
Jan 25, 2025
Commodore64user
pushed a commit
to Commodore64user/KOReader_fork
that referenced
this pull request
Jan 27, 2025
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spec/rocks/…), ensuring tests only have access to shipped packagesThis change is