Isolate 3rd party libraries used internally by Busted from test environments#654
Merged
Merged
Conversation
e0beacb to
d90135b
Compare
f61e483 to
321917d
Compare
This was referenced Aug 25, 2022
alerque
added a commit
to alerque/busted
that referenced
this pull request
Jan 7, 2026
…e/isolate-requires" This reverts commit a144124, reversing changes made to 94d0081. Reverted because the isolation is incomplete. Some penlight functions load other modules *at use*, meaning the `package.loaded` table is getting filled up with Penlight things even if we load some of them with the table out of the way. I went down the rabbit whole a ways and isollated hundreds of require functions though the code base, but it will be hard to accomplish this without introducing other bugs. With Lua 5.5 support being urgent to release, I'm reverting this so the approach isn't even changed until we decide how to really handle it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #643
Before anything else, this fixes what seems to be an unrelated bug in the loaded table state isolation. The current package loaded state table save/restore functions were only working in one direction. The packages in the current
package.loadedare restored to the state they were in at the save point, but anything that was in the save point but is no longer in the current package list (i.e. in the event of unloading a package, switching to a different version of the same package, or switching to a different isolation environment) would be left in because the keys from the save point are not iterated, only the keys from the current state.After that, this (currently) takes the approach described in my comment here, only isolating 3rd party libraries loaded by Busted for it's own use, not Busted itself.