Skip to content

ffi/util: remove dead code#1911

Merged
Frenzie merged 1 commit into
koreader:masterfrom
benoit-pierre:pr/remove_dead_code
Aug 24, 2024
Merged

ffi/util: remove dead code#1911
Frenzie merged 1 commit into
koreader:masterfrom
benoit-pierre:pr/remove_dead_code

Conversation

@benoit-pierre

@benoit-pierre benoit-pierre commented Aug 23, 2024

Copy link
Copy Markdown
Member

This change is Reviewable

@poire-z poire-z left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The less traces of "Windows" there are, the less likely one will be tempted to assume or make it work :)

@Frenzie Frenzie merged commit 1ed4685 into koreader:master Aug 24, 2024
@Frenzie

Frenzie commented Aug 24, 2024

Copy link
Copy Markdown
Member

The rest of the code all uses if ffi.os == "Windows" directly.

@benoit-pierre benoit-pierre deleted the pr/remove_dead_code branch August 24, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants