mupdf: expand list of supported CSS color names#1894
Merged
Conversation
Frenzie
approved these changes
Aug 4, 2024
Frenzie
left a comment
Member
There was a problem hiding this comment.
I'm surprised they don't have those upstream. They're liable to turn up sooner rather than later.
Contributor
|
Was dictionary rendered by something else than mupdf before the big upgrade? I remember |
Member
Author
|
Not that I'm aware, no. |
Member
|
It wouldn't have worked, no. This list of colors dates back a decade to the very first implementation: ArtifexSoftware/mupdf@bb875f7 |
Member
|
@benoit-pierre Do you still have remaining concerns about this? It looks straightforward and obvious to me. :-) |
0cede9b to
a594748
Compare
Member
Author
|
@ptrm: where you able to confirm this fix your invisible |
a594748 to
523095c
Compare
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Aug 30, 2024
koreader/koreader-base#1894 koreader/koreader-base#1908 koreader/koreader-base#1909 koreader/koreader-base#1904 koreader/koreader-base#1910 koreader/koreader-base#1911 koreader/koreader-base#1912 koreader/koreader-base#1901 koreader/koreader-base#1913 koreader/koreader-base#1680 koreader/koreader-base#1915 koreader/koreader-base#1916 koreader/koreader-base#1914
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
Aug 30, 2024
koreader/koreader-base#1894 koreader/koreader-base#1908 koreader/koreader-base#1909 koreader/koreader-base#1904 koreader/koreader-base#1910 koreader/koreader-base#1911 koreader/koreader-base#1912 koreader/koreader-base#1901 koreader/koreader-base#1913 koreader/koreader-base#1680 koreader/koreader-base#1915 koreader/koreader-base#1916 koreader/koreader-base#1914
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
koreader/koreader-base#1894 koreader/koreader-base#1908 koreader/koreader-base#1909 koreader/koreader-base#1904 koreader/koreader-base#1910 koreader/koreader-base#1911 koreader/koreader-base#1912 koreader/koreader-base#1901 koreader/koreader-base#1913 koreader/koreader-base#1680 koreader/koreader-base#1915 koreader/koreader-base#1916 koreader/koreader-base#1914
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cf. koreader/koreader#12158 (comment)
This change is