[CI] Mac OS build#1052
Merged
Merged
Conversation
GitHub Actions provides readily available Mac OS (and Windows) builds, so we should prevent the habitual Mac OS breakage from here on out. Differences from README: * ccache for obvious reasons (faster builds) * md5sha1sum caused some conflict with coreutils
Member
|
What glib/gettext issue? ^^ |
Member
Author
|
glib apparently can't find the gettext that was just built right prior to it: |
Member
Author
Member
|
Would ideally need glib's configure config.log ;). #1000 should take care of the actual build (i.e., we do rely on brew's gettext, not our own). I don't remember ever having to modify my PATH, but it's been a while (but since I use ZSH, I certainly wouldn't have recommended updating Bash's profile ;p). That said, that might be a hint: export PATH for real, don't rely on a profile that might not be used by the CI. |
Member
Author
|
Ftr, I simply copied what it said in https://github.com/koreader/koreader/blob/7b1ae4e486b9a920c0553cd654adc08668265116/doc/Building.md#macos ;-) |
Member
|
It's entirely possible that I do actually have /usr/local/* in front of my own PATH in my macOS ZSH setup, though, let me check ;). |
Member
|
Yep ^^. |
Member
|
Which makes sense ;). |
Member
Author
|
@NiLuJe Alright, that was the ticket! |
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Feb 21, 2020
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
Feb 22, 2020
* Update macOS PATH shenanigans. c.f., koreader/koreader-base#1052 * Prefer coreutils, it now ships everything we need. (Or it always did? I apparently don't actually have coreutils installed on my end). * Also recommend putting Homebrew first in PATH Mainly because it turns out that's how I tested this the last time ;). Also, it just makes sense, and might be part of Homebrew's recommendations anyway.
Frenzie
added a commit
to Frenzie/koreader-base
that referenced
this pull request
Mar 2, 2020
That way it should show. See <koreader#1052>.
Merged
Frenzie
added a commit
that referenced
this pull request
Mar 2, 2020
That way it should show. See <#1052>.
mwoz123
pushed a commit
to mwoz123/koreader
that referenced
this pull request
Mar 29, 2020
* Update macOS PATH shenanigans. c.f., koreader/koreader-base#1052 * Prefer coreutils, it now ships everything we need. (Or it always did? I apparently don't actually have coreutils installed on my end). * Also recommend putting Homebrew first in PATH Mainly because it turns out that's how I tested this the last time ;). Also, it just makes sense, and might be part of Homebrew's recommendations anyway.
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
* Update macOS PATH shenanigans. c.f., koreader/koreader-base#1052 * Prefer coreutils, it now ships everything we need. (Or it always did? I apparently don't actually have coreutils installed on my end). * Also recommend putting Homebrew first in PATH Mainly because it turns out that's how I tested this the last time ;). Also, it just makes sense, and might be part of Homebrew's recommendations anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Actions provides readily available Mac OS (and Windows) builds, so we should prevent the habitual Mac OS breakage from here on out.
Differences from README:
Hopefully @NiLuJe will be able to help resolve the gettext/glib issue because I have no idea what's going on there.
GH Actions docs: https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions
This change is