Skip to content

macOS build info tweaks#5891

Merged
Frenzie merged 4 commits into
koreader:masterfrom
NiLuJe:master
Feb 22, 2020
Merged

macOS build info tweaks#5891
Frenzie merged 4 commits into
koreader:masterfrom
NiLuJe:master

Conversation

@NiLuJe

@NiLuJe NiLuJe commented Feb 21, 2020

Copy link
Copy Markdown
Member

Following koreader/koreader-base#1052


This change is Reviewable

(Or it always did? I apparently don't actually have coreutils
installed on my end).
Mainly because it turns out that's how I tested this the last time ;).
Also, it  just makes sense, and might be part of Homebrew's
recommendations anyway.
@NiLuJe

NiLuJe commented Feb 21, 2020

Copy link
Copy Markdown
Member Author

Made it neutral: Catalina (10.15) switched the default shell to ZSH, brew info will output the right info automagically.

@Frenzie Frenzie added this to the 2020.03 milestone Feb 21, 2020
@Frenzie Frenzie merged commit c54578e into koreader:master Feb 22, 2020
mwoz123 pushed a commit to mwoz123/koreader that referenced this pull request Mar 29, 2020
* Update macOS PATH shenanigans.

c.f., koreader/koreader-base#1052

* Prefer coreutils, it now ships everything we need.

(Or it always did? I apparently don't actually have coreutils
installed on my end).

* Also recommend putting Homebrew first in PATH

Mainly because it turns out that's how I tested this the last time ;).
Also, it  just makes sense, and might be part of Homebrew's
recommendations anyway.
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
* Update macOS PATH shenanigans.

c.f., koreader/koreader-base#1052

* Prefer coreutils, it now ships everything we need.

(Or it always did? I apparently don't actually have coreutils
installed on my end).

* Also recommend putting Homebrew first in PATH

Mainly because it turns out that's how I tested this the last time ;).
Also, it  just makes sense, and might be part of Homebrew's
recommendations anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants