Conversation
|
this can be run on macos 12, and the mouse works. https://github.com/sayomelu/koreader/actions/runs/1549478342 |
| fetch-depth: 0 | ||
|
|
||
| - name: Homebrew install dependencies | ||
| # Compared to the README, adds ccache for faster compilation times and removes sh5sum to prevent some conflict with coreutils |
There was a problem hiding this comment.
sh5sum is removed, see line 21 to 23
There was a problem hiding this comment.
Yes, but you changed the comment without saying why it was justified to do so in the commit message or PR. ;-)
There was a problem hiding this comment.
This is for me to put in the squashed commit message, in other words.
There was a problem hiding this comment.
I just follow the build guide, it does not have sh5sum https://github.com/koreader/koreader/blob/master/doc/Building.md#macos
There was a problem hiding this comment.
And for future reference, that should be stated in the commit message. ;-) But I already said it was a remark from me to me. ^_^
|
Do you know what might be the case here? |
|
@sayomelu Ping? ^_^ |
|
https://github.com/sayomelu/koreader/actions/runs/1623577082 the action works correctly on my repo, but i do not know why it not work on the main repo |
|
An error like that might suggest some kind of caching-related issue? Right now I'm seeing something very odd as well. The job has been done for a while, but GHA seems to think it's still going.
|
|
Fingers crossed. 👍 |
There is a job for linters a matrix for the emulator builds and a matrix for cross compile Fix macos build based on koreader/koreader#8525
There is a job for linters a matrix for the emulator builds and a matrix for cross compile Fix macos build based on koreader/koreader#8525
Adapted from koreader/koreader#8525
Adapted from koreader/koreader#8525
Adapted from koreader/koreader#8525
This change is