Skip to content

bump crengine: support font-variant, more FB2 metadata#5980

Merged
poire-z merged 1 commit intokoreader:masterfrom
poire-z:bump_crengine
Mar 19, 2020
Merged

bump crengine: support font-variant, more FB2 metadata#5980
poire-z merged 1 commit intokoreader:masterfrom
poire-z:bump_crengine

Conversation

@poire-z
Copy link
Copy Markdown
Contributor

@poire-z poire-z commented Mar 19, 2020

Includes koreader/crengine#334

Also:


This change is Reviewable

Includes:
- FB2: merge other metadata in returned keywords and description
- CSS: adds support for font-variant
Also:
- Rebase MD5 module against upstream
- Update cURL to 7.69.1
@Frenzie Frenzie added this to the 2020.04 milestone Mar 19, 2020
@poire-z poire-z merged commit 593d770 into koreader:master Mar 19, 2020
@poire-z poire-z deleted the bump_crengine branch March 19, 2020 12:19
mwoz123 pushed a commit to mwoz123/koreader that referenced this pull request Mar 29, 2020
Includes:
- FB2: merge other metadata in returned keywords and description
- CSS: adds support for font-variant
Also:
- Rebase MD5 module against upstream
- Update cURL to 7.69.1
@poire-z
Copy link
Copy Markdown
Contributor Author

poire-z commented Apr 10, 2020

Would it be worth adding this style tweak? :
Disable ligatures (in kerning mode 'best') * { font-variant: no-common-ligatures; }

(I had a moment when I found ligatures ugly - it has passed :) - and tried this, and it works.)

If yes, where:
image
Would a sub-menu Hyphenation and ligatures> be ok, to not make this one taller?

(And the more we add features that work only well in "best" kerning mode, the hacky "good" mode feels a bit less needed - vs "fast" that might be good enough for most people that need speed. And when adding features to crengine, I always have a moment I have to think about that mode, and wonder how to make that thing work - often ending not having it work in that mode (font-variants, HB font languages...), and often not testing much it :) So, I don't know, may be we could remove it ?)

@mergen3107
Copy link
Copy Markdown
Contributor

I use “good” most of the time due to speed/quality balance. “Fast” is really fast, but some parts of text look a little out of place. “Best” is some times very slow for large books (1000+ CR pages)

@poire-z
Copy link
Copy Markdown
Contributor Author

poire-z commented Apr 10, 2020

OK, so let's keep "good" :)
(Could that be specific to cyrillic ? I have never really noticed any issue with "fast" with latin letters text.)

@NiLuJe
Copy link
Copy Markdown
Member

NiLuJe commented Apr 10, 2020

IIRC, "fast" only does legacy kerning (i.e, kern tables vs. GPOS tables), which might indeed be an issue with some fonts ;).

@mergen3107
Copy link
Copy Markdown
Contributor

Unfortunately, I can't remember or reproduce exact reason I didn't like fast so much.
One thing for sure if that if has different spaces between small words, but this effect is insignificant (e.g. produces 370 CR pages instead of 368 in good rendering):
fast:
Reader_2020-Apr-10_175203
good:
Reader_2020-Apr-10_175223

I am sure about Cyrillic-specific deterioration neither. good's description explicitly warns about lack of support for non-western characters anyway :D

@mergen3107
Copy link
Copy Markdown
Contributor

This is on KOReader Stable v2020.03.2 on Kindle PW3 (5.9.7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggestions: show annotation in FM on long tap Enhancement proposed: to display Open Type layout features.

4 participants