CSS: adds support for font-variant - More FB2 metadata#334
Merged
poire-z merged 2 commits intokoreader:masterfrom Mar 19, 2020
Merged
CSS: adds support for font-variant - More FB2 metadata#334poire-z merged 2 commits intokoreader:masterfrom
poire-z merged 2 commits intokoreader:masterfrom
Conversation
Also have Harfbuzz full and Harfbuzz light reuse the same _hb_buffer and _hb_features to keep things simpler.
Frenzie
approved these changes
Mar 18, 2020
Member
Frenzie
left a comment
There was a problem hiding this comment.
I basically only skimmed through the large lists of features but it all looks sensible.
This was referenced Mar 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSS: adds support for font-variantDetails around koreader/koreader#5821 (comment)
Most values from CSS-FONTS-3 (31 named-values) are supported, see the code for the list.
Only
font-variantand its buddies (font-variant-caps,font-variant-ligatures...) are parsed, but it could be extended to also supportfont-feature-settings.https://drafts.csswg.org/css-fonts-3/#propdef-font-variant
https://developer.mozilla.org/en-US/docs/Web/CSS/font-variant
https://en.wikipedia.org/wiki/List_of_typographic_features
https://docs.microsoft.com/en-us/typography/opentype/spec/features_ko#tag-onum
Note that I haven't thought about how font-variant should be handled when we need to use the fallback font - so, the fallback font should have currently no OT feature enabled.
@virxkane @pkb: when/if you pick up this one, you'll have a bit of merging work as it touches lvfntman.cpp, that you have splitted on your side (thought about easing that for you and making it 2 commits, but the split wasn't obvious, and it feels better as a single commit here).
FB2: merge other metadata in returned keywords and descriptionFB2 has a lot more metadata than other formats, so try to merge and fit them in the 2 available returned metadata slots that weren't used by FB2: Description & Keywords.
Details around koreader/koreader#5956 (comment)
This change is