Skip to content

tools: fix update-metadata#15132

Merged
Frenzie merged 1 commit into
koreader:masterfrom
benoit-pierre:pr/fix_update-metadata_tool
Mar 19, 2026
Merged

tools: fix update-metadata#15132
Frenzie merged 1 commit into
koreader:masterfrom
benoit-pierre:pr/fix_update-metadata_tool

Conversation

@benoit-pierre

@benoit-pierre benoit-pierre commented Mar 19, 2026

Copy link
Copy Markdown
Member

Save appstream metadata to new location (Cf. #15116).


This change is Reviewable

Save appstream metadata to new location (Cf. koreader#15116).
@pazos

pazos commented Mar 19, 2026

Copy link
Copy Markdown
Member

Do the tool still updates translations properly after switching to binary format? If so, it is possible to add a make/kodev target to build and update the metadata translations?

@Frenzie Frenzie added this to the 2026.05 milestone Mar 19, 2026
@Frenzie Frenzie merged commit 3f5cd7f into koreader:master Mar 19, 2026
4 checks passed
@benoit-pierre benoit-pierre deleted the pr/fix_update-metadata_tool branch March 20, 2026 00:50
@benoit-pierre

Copy link
Copy Markdown
Member Author

Do the tool still updates translations properly after switching to binary format? If so, it is possible to add a make/kodev target to build and update the metadata translations?

There's already a mo target for that.

The tool should probably be used as part of bumping translations before a release, however:

▸ make V=1 mo
make --jobs=8  --silent --file=make/gettext.mk l10n/af_ZA/koreader.mo l10n/ar/koreader.mo l10n/be/koreader.mo l10n/bg_BG/koreader.mo l10n/bn/koreader.mo l10n/ca/koreader.mo l10n/cs/koreader.mo l10n/cy/koreader.mo l10n/da/koreader.mo l10n/de/koreader.mo l10n/el/koreader.mo l10n/en_GB/koreader.mo l10n/eo/koreader.mo l10n/es/koreader.mo l10n/et/koreader.mo l10n/eu/koreader.mo l10n/fa/koreader.mo l10n/fi/koreader.mo l10n/fr/koreader.mo l10n/ga/koreader.mo l10n/gl/koreader.mo l10n/he/koreader.mo l10n/hi/koreader.mo l10n/hr/koreader.mo l10n/hu/koreader.mo l10n/ia/koreader.mo l10n/id/koreader.mo l10n/ie/koreader.mo l10n/it_IT/koreader.mo l10n/ja/koreader.mo l10n/kab/koreader.mo l10n/ka/koreader.mo l10n/kn/koreader.mo l10n/ko_KR/koreader.mo l10n/lt_LT/koreader.mo l10n/lv/koreader.mo l10n/mk/koreader.mo l10n/ms/koreader.mo l10n/nb_NO/koreader.mo l10n/nl_NL/koreader.mo l10n/or/koreader.mo l10n/pl/koreader.mo l10n/pt_BR/koreader.mo l10n/pt_PT/koreader.mo l10n/ro/koreader.mo l10n/ro_MD/koreader.mo l10n/ru/koreader.mo l10n/si/koreader.mo l10n/sk/koreader.mo l10n/sl/koreader.mo l10n/sr/koreader.mo l10n/sv/koreader.mo l10n/th/koreader.mo l10n/tr/koreader.mo l10n/uk/koreader.mo l10n/ur/koreader.mo l10n/vi/koreader.mo l10n/zh_CN/koreader.mo l10n/zh_TW/koreader.mo
make[1]: warning: -j8 forced in submake: resetting jobserver mode.
msgfmt --no-hash -o l10n/af_ZA/koreader.mo l10n/af_ZA/koreader.po
[…]
msgfmt --no-hash -o l10n/zh_TW/koreader.mo l10n/zh_TW/koreader.po

▸ ./tools/update-metadata.lua
Building appstream metadata, this might take a while...
Building fastlane metadata
All done! Updated files:
platform/linux/koreader.metainfo.xml
metadata/en-US/short_description.txt
[…]
metadata/zh_TW/full_description.txt

▸ git diff --ignore-submodules --stat
 metadata/el/full_description.txt     |  2 +-
 metadata/hu/full_description.txt     |  2 +-
 metadata/ro_MD/full_description.txt  |  2 +-
 metadata/zh_CN/full_description.txt  |  2 +-
 platform/linux/koreader.metainfo.xml | 76 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------
 5 files changed, 74 insertions(+), 10 deletions(-)

▸ git status --ignore-submodules  metadata
On branch master
Your branch is ahead of 'origin/master' by 1 commit.

Changes not staged for commit:
	modified:   metadata/el/full_description.txt
	modified:   metadata/hu/full_description.txt
	modified:   metadata/ro_MD/full_description.txt
	modified:   metadata/zh_CN/full_description.txt

Untracked files:
	metadata/be/ metadata/ga/ metadata/hr/ metadata/id/ metadata/sl/ metadata/sv/ metadata/vi/

no changes added to commit

0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Save appstream metadata to new location (Cf. koreader#15116).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants