Skip to content

drop appimage target in favor of linux#15116

Merged
Frenzie merged 12 commits into
koreader:masterfrom
benoit-pierre:pr/appimage_linux_targets_rework
Mar 15, 2026
Merged

drop appimage target in favor of linux#15116
Frenzie merged 12 commits into
koreader:masterfrom
benoit-pierre:pr/appimage_linux_targets_rework

Conversation

@benoit-pierre

@benoit-pierre benoit-pierre commented Mar 15, 2026

Copy link
Copy Markdown
Member

Cf. koreader/kobase#2298.

The linux update target now build an AppImage too.

Other miscellaneous changes:

  • AppImage:
    • better icons
    • update filename to conform to spec (ApplicationName-$VERSION-$ARCH.AppImage)
    • running from extracted contents will behave like the Linux distribution (multi-user mode)
  • Debian package:
    • better icons
    • update version to include git commit
    • drop fakeroot requirement for building
    • fix dependencies (based on our targeted Ubuntu LTS: 22.04, AKA Jammy)
  • Linux distribution:
    • better icons
    • improved start-up script (can be symlinked to)

Additionally:

  • split update rules, and update kodev release command to support it
  • fix AppImage OTA model: take architecture into account

This change is Reviewable

@benoit-pierre benoit-pierre force-pushed the pr/appimage_linux_targets_rework branch from 124cd0a to 4ad7bfb Compare March 15, 2026 20:45
@benoit-pierre

Copy link
Copy Markdown
Member Author

Patch for nightly-builds.

benoit-pierre added a commit to benoit-pierre/virdevenv that referenced this pull request Mar 15, 2026
benoit-pierre added a commit to benoit-pierre/virdevenv that referenced this pull request Mar 15, 2026
@Frenzie

Frenzie commented Mar 15, 2026

Copy link
Copy Markdown
Member

This all looks great! Btw, did you already run those PNGs through optipng or similar?

@benoit-pierre

Copy link
Copy Markdown
Member Author

Through pngcrush, yes.

Frenzie pushed a commit to koreader/virdevenv that referenced this pull request Mar 15, 2026
@Frenzie Frenzie added this to the 2026.02 milestone Mar 15, 2026
Fix lintian warnings: executable-not-elf-or-script.
For a generally faster multi-threading compression speed, with only a very minor size increase.
Cf. koreader/kobase#2298.

The `linux` update target now build an AppImage too.

Other miscellaneous changes:
- AppImage:
  * better icons
  * update filename to conform to spec (`ApplicationName-$VERSION-$ARCH.AppImage`)
  * running from extracted contents will behave like the Linux distribution (multi-user mode)
- Debian package:
  * better icons
  * update version to include git commit
  * drop fakeroot requirement for building
  * fix dependencies (based on our targeted Ubuntu LTS: 22.04, AKA Jammy)
- Linux distribution:
  * better icons
  * improved start-up script (can be symlinked to)
Example: `./kodev release linux deb` will only build the Debian package (not the AppImage & Linux distribution).
Account for architecture.
@benoit-pierre benoit-pierre force-pushed the pr/appimage_linux_targets_rework branch from 4ad7bfb to 975e8e3 Compare March 15, 2026 21:54
@benoit-pierre benoit-pierre marked this pull request as ready for review March 15, 2026 21:54
@benoit-pierre benoit-pierre requested a review from Frenzie as a code owner March 15, 2026 21:54
@Frenzie Frenzie merged commit c1e3e58 into koreader:master Mar 15, 2026
4 checks passed
@benoit-pierre benoit-pierre deleted the pr/appimage_linux_targets_rework branch March 15, 2026 22:08
benoit-pierre added a commit to benoit-pierre/koreader that referenced this pull request Mar 19, 2026
Save appstream metadata to new location (Cf. koreader#15116).
Frenzie pushed a commit that referenced this pull request Mar 19, 2026
Save appstream metadata to new location (Cf. #15116).
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Save appstream metadata to new location (Cf. koreader#15116).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants