Resolves #14026 (if deemed useful)

Do you think other actions from this chunk are not needed?

Maybe we need both actions: toggle and enable/disable?
Like in

Maybe we need both actions: toggle and enable/disable? Like in

koreader/plugins/statistics.koplugin/main.lua

Line 1061 in 6a56740

function ReaderStatistics:onToggleStatistics(arg)

Yeah that seems useful and consistent, thanks for the reference.

https://github.com/koreader/koreader/pull/14037/files#diff-470e6a4f5987f335136219d0e66fb62ce77d77c75292fbea06f09f4808245b20R168-R170

https://github.com/koreader/koreader/pull/14037/files#diff-470e6a4f5987f335136219d0e66fb62ce77d77c75292fbea06f09f4808245b20R927-R929

(Sorry cant seem to get the hang on embedding the PR code somehow)

Do you think other actions from this chunk are not needed?

koreader/plugins/kosync.koplugin/main.lua

Lines 223 to 246 in 6a56740

	{
	text = _("Automatically keep documents in sync"),
	checked_func = function() return self.settings.auto_sync end,
	help_text = _([[This may lead to nagging about toggling WiFi on document close and suspend/resume, depending on the device's connectivity.]]),
	callback = function()
	-- Actively recommend switching the before wifi action to "turn_on" instead of prompt, as prompt will just not be practical (or even plain usable) here.
	if Device:hasSeamlessWifiToggle() and G_reader_settings:readSetting("wifi_enable_action") ~= "turn_on" and not self.settings.auto_sync then
	UIManager:show(InfoMessage:new{ text = _("You will have to switch the 'Action when Wi-Fi is off' Network setting to 'turn on' to be able to enable this feature!") })
	return
	end
	self.settings.auto_sync = not self.settings.auto_sync
	self:registerEvents()
	if self.settings.auto_sync then
	-- Since we will update the progress when closing the document,
	-- pull the current progress now so as not to silently overwrite it.
	self:getProgress(true, true)
	else
	-- Since we won't update the progress when closing the document,
	-- push the current progress now so as not to lose it.
	self:updateProgress(true, true)
	end
	end,
	},

Agreed, this would be inconsistent.
Although I would skip

To avoid code duplication call the method in the menu callback.

function KOSync:onToggleAutoSync(toggle, from_menu)
    if toggle == self.settings.auto_sync then return true end
    -- Actively recommend switching the before wifi action to "turn_on" instead of prompt,
    -- as prompt will just not be practical (or even plain usable) here.
    if not self.settings.auto_sync
            and Device:hasSeamlessWifiToggle()
            and G_reader_settings:readSetting("wifi_enable_action") ~= "turn_on" then
        UIManager:show(InfoMessage:new{ text = _("You will have to switch the 'Action when Wi-Fi is off' Network setting to 'turn on' to be able to enable this feature!") })
        return true
    end
    self.settings.auto_sync = not self.settings.auto_sync
    self:registerEvents()
    if self.settings.auto_sync then
        -- Since we will update the progress when closing the document,
        -- pull the current progress now so as not to silently overwrite it.
        self:getProgress(true, true)
    elseif from_menu then
        -- Since we won't update the progress when closing the document,
        -- push the current progress now so as not to lose it.
        self:updateProgress(true, true)
    end
    if not from_menu then
        Notification:notify(self.settings.auto_sync and _("Auto progress sync: on") or _("Auto progress sync: off"))
    end
    return true
end

EDIT: toggle is honored in the beginnig.