fixes #13669

Incidentally just caught that in a Nickel changelog when updating a device today.

I'm not entirely sure if the page turn keys are actual wakeup sources on older devices with keys, but I would assume so, so, eeeh, why not.

Incidentally just caught that in a Nickel changelog when updating a device today.

I'm not entirely sure if the page turn keys are actual wakeup sources on older devices with keys, but I would assume so, so, eeeh, why not.

I can verify tonight on a forma (tested this initially on a KLC to see it work, and a Clara2E to see it not break :) ) Assuming a Forma counts as an older device these days

Verified works on the forma, fwiw.

Verified works on the forma, fwiw.

I'm mistaken. Looking into why t doesn't work.

fixes #13668

This needs to go in the original post #13669 (comment)

Verified works on the forma, fwiw.

I'm mistaken. Looking into why t doesn't work.

I assume simply because the page turn buttons are not a wakeup source, so the kernel doesn't even wake the device up.

I'm mistaken. Looking into why t doesn't work.

I assume simply because the page turn buttons are not a wakeup source, so the kernel doesn't even wake the device up.

If I had only seen this a few hours ago...but yes, the forma is missing the wakeup-source for the buttons (but has wakeup), which I think explains why the buttons work to wake up in the first minute or so, but not once hibernation has started (anecdotal, but I've noticed the forma isn't completely hibernating after a power button press, probably as it runs through suspension).

Looking now to see if I can figure out which devices support wakeup-source so I can at least tune this proposal a little better. Also to apply it correctly as was pointed out :)

I think it's only the KLC that supports it. None of the other devices have any mention of it in the latest FW release notes:

https://pgaskin.net/KoboStuff/kobofirmware.html

why the buttons work to wake up in the first minute or so

Yes, suspend entry is delayed by something like 45s (for... ntx reasons).

Looking now to see if I can figure out which devices support wakeup-source

Checking the dtb might be a littler overkill (and potentially brittle ;p).

I wouldn't expect the Libra 1/2 to be any different than the Forma, given the board similarities, soo, yeah, I would assume it's MTK-only (for... now?).

I wouldn't expect the Libra 1/2 to be any different than the Forma, given the board similarities, soo, yeah, I would assume it's MTK-only (for... now?).

I'll check on the Sage for good measure.

I'll check on the Sage for good measure

That would be a no on sunxi:

/sys/firmware/devicetree/base/soc@03000000/gpio-keys/
|-- autorepeat
|-- combo
|   |-- gpios
|   |-- label
|   |-- linux,code
|   |-- name
|   `-- wakeup-source
|-- compatible
|-- hall
|   |-- gpios
|   |-- label
|   |-- linux,code
|   |-- name
|   `-- wakeup-source
|-- name
|-- pagedown
|   |-- gpios
|   |-- label
|   |-- linux,code
|   `-- name
|-- pageup
|   |-- gpios
|   |-- label
|   |-- linux,code
|   `-- name
`-- power
    |-- gpios
    |-- label
    |-- linux,code
    |-- name
    `-- wakeup-source

So, yeah, gating it behind isKobo + isMTK ought to do it.

I think it's only the KLC that supports it. None of the other devices have any mention of it in the latest FW release notes:

https://pgaskin.net/KoboStuff/kobofirmware.html

I have to agree (shame though) - given kobo is shy about upgrading kernels (and presumably modules), it's only with the latest release that it looks like this is available.

Updated label and added condition for isMTK. I suspect it's just that the MTK devices have newer kernels and therefore have the ability to set the gpio flags, but at this time new kernel is the same as MTK. In theory someone could compile a newer kernel for their device, or non-kobo's with newer kernel's with gpio compiled in, could also activate this feature. Given that it's currently tied only to one release of kobo, I'd understand if this was rejected. Thanks!

Yeah, I'm slooooowwwly catching up, this is next on my list, ideally this week-end ;).

Folks, can you point me to where I should be seeing the menu option? I dug around and don’t see the option on a libra 2. I’m on the latest stable version.

Thanks in advance

The Libra 2 doesn't support this feature (as this requires cooperation from the kernel), which is why you can't find it.

But if you ever find yourself looking for a setting that is available on your device, there's a search available in the help section of the top menu ;).