Skip to content

ReaderUI: fix BookList cache#13245

Merged
hius07 merged 4 commits into
koreader:masterfrom
hius07:fix-booklist-cache
Feb 13, 2025
Merged

ReaderUI: fix BookList cache#13245
hius07 merged 4 commits into
koreader:masterfrom
hius07:fix-booklist-cache

Conversation

@hius07

@hius07 hius07 commented Feb 12, 2025

Copy link
Copy Markdown
Member

Updating of percent_finished for rolling is triggered by the CloseDocument event, so refresh the cache after it.
Closes #13244.


This change is Reviewable

@hius07 hius07 marked this pull request as draft February 12, 2025 13:02
@hius07 hius07 marked this pull request as ready for review February 12, 2025 13:18
@hius07

hius07 commented Feb 12, 2025

Copy link
Copy Markdown
Member Author

But for paging it should be done even later, after the SaveSettings event.

@hius07

hius07 commented Feb 12, 2025

Copy link
Copy Markdown
Member Author

For reference

-- we cannot do it in onSaveSettings() because getLastPercent() uses self.ui.document
self.ui.doc_settings:saveSetting("percent_finished", self:getLastPercent())

self.ui.doc_settings:saveSetting("percent_finished", self:getLastPercent())

@hius07 hius07 merged commit 435c286 into koreader:master Feb 13, 2025
@hius07 hius07 deleted the fix-booklist-cache branch February 13, 2025 15:53
@hius07 hius07 added this to the 2025.02 milestone Feb 13, 2025
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Read pages percentage not updating in detailed list file browser

2 participants