GestureDetector: Translate start & end gesture positions when rotated#13101
Merged
Conversation
direction translation That function call wrapper felt pretty unnecessary to me ;).
i.e., if there's a start and end position, translate those, too. Fix koreader#13090
Member
Author
|
Testing welcome, as I'm fairly short on time right now ;). |
Member
|
When were they added and/or what depends on them precisely? |
Member
|
Works good! |
Member
Author
It seemed familiar... #10649 ;o).
Whee, thanks! |
Frenzie
approved these changes
Jan 20, 2025
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
…koreader#13101) * GestureDetector:adjustGesCoordinate: Remove one layer of indirectiçon in direction translation That function call wrapper felt pretty unnecessary to me ;). * GestureDetector: Translate complex gesture positions, too i.e., if there's a start and end position, translate those, too. Fix koreader#13090
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That somehow slipped through the cracks when those fields were added...
Fix #13090
This change is