It's looks good (as far as the screenshots go) but why don't you apply those [applicable] changes to hotkeys as well? The way I see it; gestures, profiles and hotkeys are “The Three Musketeers”

Not too sure about using check boxes to indicate insertion of a separator, seems more like activating/deactivating the action.

It looks like a checkbox means "place separator after this item"

I don't want to blow up the SortWidget for this special usecase.
Checkbox means separator after the item.

Also closes #10534 👍

Not too sure about using check boxes to indicate insertion of a separator, seems more like activating/deactivating the action.
Checkbox means separator after the item.

Not intuitive at all :/
I guess QuickMenu is an advanced features and people read here and will know about it, so it's ok.
But may be our CheckBox/CheckMark could have an option underscore_container so it appears as an underscore instead of a rounded square - with the checkbox above it. It would then be a little bit more intuitive that
"Checkbox Checked underline means separator after the item"

There is a poor-man's [different] approach here #13056 (comment), it works, i can't upload the link with the diff atm but could later.

It does indeed look more like enable/disable without explicitly deleting. Another potential thought in line with what @poire-z wrote ("an option underscore_container so it appears as an underscore instead of a rounded square"), is that perhaps you could actively add a separate/underline under the item when you check it.

To me just a regular checkbox is fine.

Can't say I'm fond of that :) but neither of the checkboxes. No other idea...

this is what I have @hius07 https://github.com/koreader/koreader/compare/master...Commodore64user:sort-sep?expand=1

if you like what you see, I can PR it and you could take it from there. Of course I am completely biased here, but I think this is the right way to do it. ;)

@Commodore64user
Your link above took me to a "Create new Pull request" page

you should be able to see the diff, can you not?

I see this

Maybe because I am on mobile

Ah, sorry. My bad

GitHub on Safari has been acting up so badly recently.

That page above apparently needs 30-60 seconds to load fully.

Also, usual "compare" page never gets loaded anymore, so frustrating

I like it. Clarity may not be ideal (maybe it's just underlined to show it's selected) but it sure beats the other options.

A small wording change could make it clearer: "Arrange actions, add QuickMenu separators". Because the separators are not really arranged. (And the last checkbox is not really needed.)

That looks better, yes, and it's far less over-engineered (guilty). I agree with Frenzie that the checkboxes (and ticks) are not needed, and with Jonny about the wording change.

Also overriding #12866, thanks @thialfi17.

Tapping on a checkbox toggles it (along with long-pressing on an item).

that looks quite nice, no checkbox (although you could still tap that area to toggle the separator) and lower the rule just a bit so it looks a little less like un underline. long-press is great too as it would work nicely on NT.

this method is somehow broken on NT, no matter where you try to add a separator, it will only add it to the first item in the list. Similarly, if you go to manage dictionaries, and try to untick any dictionary in position n > 1, only and always the very first will get unticked.